Dep warnings for dict mapping

[richardjgowers]

smoothes over a change made in PR #260

[pep8speaks]

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file gufe/protocols/protocol.py:

Line 180:80: E501 line too long (104 > 79 characters)

• In the file gufe/tests/test_protocol.py:

Line 336:80: E501 line too long (97 > 79 characters)

• In the file gufe/tests/test_transformation.py:

Line 127:80: E501 line too long (90 > 79 characters)
Line 129:80: E501 line too long (80 > 79 characters)
Line 136:80: E501 line too long (82 > 79 characters)

• In the file gufe/transformations/transformation.py:

Line 28:80: E501 line too long (111 > 79 characters)

Comment last updated at 2024-03-13 11:28:55 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (4527364) to head (2d6db93).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   98.93%   98.94%           
=======================================
  Files          36       36           
  Lines        1978     1986    +8     
=======================================
+ Hits         1957     1965    +8     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikemhenry]

LGTM! Do we want to add something about backwards compatibility being removed in version 1.x or 2.x? If we are not sure then we can leave it vague like this and add the version where we drop it later

[richardjgowers]

@mikemhenry Yeah I wasn't sure when we'd ever have to remove these lines. It's not that bad to keep in the shim for all of 1.x. If/when we find a reason this can't stay we can add a deprecation removal date in the message