Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ExecutionInterrupt (special exception) #459

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 16, 2025

Resolves #392

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from dotsdl January 16, 2025 17:08
@atravitz atravitz self-assigned this Jan 16, 2025
@atravitz atravitz force-pushed the add_special_exception branch from 43c6ecc to 6130d6a Compare January 16, 2025 17:09
@atravitz
Copy link
Contributor Author

pre-commit.ci autofix

@atravitz atravitz marked this pull request as draft January 16, 2025 17:36
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (f8baf7f) to head (e42ad88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          39       39           
  Lines        2166     2168    +2     
=======================================
+ Hits         2134     2136    +2     
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz marked this pull request as ready for review January 16, 2025 19:01
Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @atravitz! Please merge if satisfied!

gufe/protocols/protocolunit.py Outdated Show resolved Hide resolved
@atravitz atravitz merged commit d472237 into main Jan 17, 2025
13 checks passed
@atravitz atravitz deleted the add_special_exception branch January 17, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add special Exception subclass that won't be caught by ProtocolUnit.execute
2 participants