ntp: resection manual-pages according to IPD4, rebuild for library/se… #19993

klausz65 · 2024-12-13T09:06:13Z

…curity/openssl-3

mtelka · 2024-12-13T09:15:56Z

components/network/ntp/Makefile

@@ -44,6 +45,7 @@ COMPONENT_FMRI=	service/network/ntp
 COMPONENT_CLASSIFICATION=	System/Services
 COMPONENT_LICENSE=	ntp license
 COMPONENT_LICENSE_FILE=	COPYRIGHT
+COMPONENT_BUILD_ARGS=	-j20


Please never do this. Use USE_PARALLEL_BUILD instead.

mtelka · 2024-12-13T09:16:19Z

components/network/ntp/Makefile

@@ -53,6 +55,7 @@ include $(WS_MAKE_RULES)/common.mk

 # We modified configure.ac and m4 macros
 COMPONENT_PREP_ACTION = ( cd $(@D) && PATH="$(PATH)" ./bootstrap )
+COMPONENT_POST_CONFIGURE_ACTION += ( cd $(BUILD_DIR_64)/ntpd; gmake ntp_parser.h)


Please add a comment explaining why is this needed. Thank you.

mtelka · 2024-12-13T09:20:31Z

components/network/ntp/patches/10-etcfix.patch

+  */
+-#ifdef HAVE_SYS_AUDIOIO_H
+-static struct audio_device device; /* audio device ident */
+-#endif /* HAVE_SYS_AUDIOIO_H */


This change is not related to paths customization (see top of this file). If this is really needed please add such a change as a new patch with a comment explaining why it is needed. Thank you.

mtelka · 2024-12-13T09:22:42Z

components/network/ntp/ntp.p5m

@@ -19,7 +19,7 @@
 # CDDL HEADER END
 #
 # Copyright (c) 2011, 2013, Oracle and/or its affiliates. All rights reserved.
-# Copyright (c) 2023, Friedrich Kink. All rights reserved.


Please never remove copyrights of others without their consent.

changed back

Where is Friedrich Kink? What exactly you added back?

have forgotten git add for ntp.p5m

mtelka · 2024-12-13T09:23:39Z

components/network/ntp/patches/60-rem-vpath_after-ntpd.patch

@@ -0,0 +1,11 @@
+--- ntpd/Makefile.am.orig	2023-05-31 12:31:38.000000000 +0200


Please add a comment explaining why we do need this. Thank you.

mtelka · 2024-12-13T09:23:45Z

components/network/ntp/patches/70-warrnigs.patch

@@ -0,0 +1,62 @@
+--- util/ntptime.c.orig	2020-03-04 00:41:29.000000000 +0100


Please add a comment explaining why we do need this. Thank you.

BTW, the patch filename contains typo (two r, missing n).

klausz65 · 2024-12-14T11:36:04Z

The new results-all.master test file needs pull #20032

mtelka · 2024-12-14T12:47:43Z

The new results-all.master test file needs pull #20032

It does not. You can simply do something like COMPONENT_TEST_ARGS += -k here.

mtelka · 2024-12-14T12:51:34Z

components/network/ntp/Makefile

@@ -26,12 +26,14 @@
 # Copyright (c) 2023, Niklas Poslovski
 #

+# for the moment the SHAKE128 digest fails
+USE_DEFAULT_TEST_TRANSFORMS= yes


Is the results-all.master reproducible with this?

mtelka · 2024-12-14T12:52:37Z

components/network/ntp/Makefile

@@ -26,12 +26,14 @@
 # Copyright (c) 2023, Niklas Poslovski
 #

+# for the moment the SHAKE128 digest fails


I believe this comment does not belong here. Why do we need it at all? Isn't the test failure visible in results-all.master. If not, why?

Isn't it possible to skip the test instead?

mtelka · 2024-12-14T12:54:10Z

components/network/ntp/ntp.p5m

@@ -19,7 +19,7 @@
 # CDDL HEADER END
 #
 # Copyright (c) 2011, 2013, Oracle and/or its affiliates. All rights reserved.
-# Copyright (c) 2023, Friedrich Kink. All rights reserved.


Where is Friedrich Kink? What exactly you added back?

mtelka · 2024-12-14T12:57:23Z

components/network/ntp/test/results-all.master

-   sntp : tests/test-suite.log
-=========================================
-
+FAIL: test-crypto


With the new results-all.master I miss the list of tests. It is always good to have such a list so we are able to detect when the number of failing tests didn't change, but instead of test1 failure we now see the test2 failing.

I don't get you here

I don't get you here

Since you reverted this change then it makes little sense to discuss it.

mtelka · 2024-12-14T16:53:21Z

components/network/ntp/Makefile

@@ -54,6 +54,8 @@ include $(WS_MAKE_RULES)/common.mk
 # We modified configure.ac and m4 macros
 COMPONENT_PREP_ACTION = ( cd $(@D) && PATH="$(PATH)" ./bootstrap )

+COMPONENT_TEST_ARGS += -k


Please add a comment explaining why is this needed. Thank you.

mtelka · 2024-12-14T16:57:36Z

components/network/ntp/test/results-all.master

@@ -1,22 +1,25 @@
-crypto.c:14:test_MakeSHAKE128Mac:PASS
+make_mac: MAC SHAKE128 Digest Final failed.


This is apparently a regression. I've no idea what would be the impact of this but it could possibly cause that something won't work as expected. Since ntpd is core part of system (and I would like to avoid reports that people are no longer able to sync their time properly) then please try to find why is this failing now.

Thank you.

I allready tried, but sorry I'm too dump to fix this, if you want to have that IPD4 part, you'll have to take this PR as it is otherwise tell me and I'll cancel it.

I allready tried, but sorry I'm too dump to fix this, if you want to have that IPD4 part, you'll have to take this PR as it is otherwise tell me and I'll cancel it.

Quick search revealed that the problem is very likely caused by a change in OpenSSL 3.4.

Related links:

EVP_DigestFinal() and EVP_Digest() should fail for SHAKE-128 and SHAKE-256 unless the xoflen param is set openssl/technical-policies#93

SHAKE-128 and SHAKE-256 implementations have no default digest length erlang/otp#8997

Fix crypto:hash_final/1 for shake128/256 on OpenSSL >= 3.4 erlang/otp#9002

I can't fix this - sorry

…curity/openssl-3

klausz65 marked this pull request as draft December 13, 2024 09:06

mtelka suggested changes Dec 13, 2024

View reviewed changes

klausz65 force-pushed the ntp branch 4 times, most recently from 702979f to a023fb6 Compare December 14, 2024 11:34

klausz65 marked this pull request as ready for review December 14, 2024 11:34

mtelka suggested changes Dec 14, 2024

View reviewed changes

klausz65 force-pushed the ntp branch 3 times, most recently from 487a858 to d6788d4 Compare December 14, 2024 14:17

mtelka suggested changes Dec 14, 2024

View reviewed changes

ntp: resection manual-pages according to IPD4, rebuild for library/se…

8108c42

…curity/openssl-3

klausz65 force-pushed the ntp branch from d6788d4 to 8108c42 Compare December 14, 2024 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ntp: resection manual-pages according to IPD4, rebuild for library/se… #19993

ntp: resection manual-pages according to IPD4, rebuild for library/se… #19993

klausz65 commented Dec 13, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

mtelka Dec 13, 2024

mtelka Dec 13, 2024

klausz65 Dec 14, 2024

klausz65 commented Dec 14, 2024

mtelka commented Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024

mtelka Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024

mtelka Dec 14, 2024

mtelka Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024

mtelka Dec 14, 2024

klausz65 Dec 14, 2024 •

edited

Loading

		@@ -0,0 +1,11 @@
		--- ntpd/Makefile.am.orig 2023-05-31 12:31:38.000000000 +0200

		@@ -0,0 +1,62 @@
		--- util/ntptime.c.orig 2020-03-04 00:41:29.000000000 +0100

		@@ -1,22 +1,25 @@
		crypto.c:14:test_MakeSHAKE128Mac:PASS
		make_mac: MAC SHAKE128 Digest Final failed.

ntp: resection manual-pages according to IPD4, rebuild for library/se… #19993

Are you sure you want to change the base?

ntp: resection manual-pages according to IPD4, rebuild for library/se… #19993

Conversation

klausz65 commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klausz65 commented Dec 14, 2024

mtelka commented Dec 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klausz65 Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

klausz65 Dec 14, 2024 •

edited

Loading