Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeliver #30472 after fixing break #30532

Merged

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Jan 10, 2025

This PR contains all of the commits from #30472 in order to deliver it, plus an additional commit to update io.openliberty.data.internal_fat_errorpaths to expect the added error message and its cause error message that is now detected. Fixes #30537

It should be noted that this test bucket erroneously did not run or appear in the pipeline results for #30472, so remember to double check that it appears for this PR. (Hopefully it will now regardless given that files within it have now been updated)

@njr-11
Copy link
Contributor Author

njr-11 commented Jan 10, 2025

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@njr-11
Copy link
Contributor Author

njr-11 commented Jan 10, 2025

Note to ID reviewers (@OpenLiberty/message-reviewer) - there is no need to review this even though it contains an NLS message because you already reviewed it under 30472, which this is redelivering. There are no further changes to the message.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 10 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_shp2YNAEEe-f-sI4gb7_Pw

Target locations of links might be accessible only to IBM employees.

@njr-11
Copy link
Contributor Author

njr-11 commented Jan 13, 2025

#build (view Open Liberty Personal Build - ✅ completed successfully!)
(view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

This time the build did run io.openliberty.data.internal_fat_errorpaths. This bucket (and the result of the build) passed.

Note: Target locations of links might be accessible only to IBM employees.

@njr-11 njr-11 merged commit 5755db4 into OpenLiberty:integration Jan 13, 2025
3 checks passed
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 10 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_pY4d8NHNEe-oy5en10XsVA

Target locations of links might be accessible only to IBM employees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-introduce change reverted from 30472
3 participants