Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EngineDecks now take scale factor as an input #565

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jkirk5
Copy link
Contributor

@jkirk5 jkirk5 commented Oct 10, 2024

Summary

Flipped engine sizing so scale factor is and input and target (scaled) thrust is an output, to better match how alternative propulsion systems are handled (such as motors)

Some light cleanup of FLOPS-based model data files to make it easer to determine what values are being set for each input

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@jkirk5 jkirk5 marked this pull request as ready for review December 6, 2024 21:41
@jkirk5 jkirk5 changed the base branch from main to 0.9.6.dev December 6, 2024 21:45
@jkirk5 jkirk5 changed the base branch from 0.9.6.dev to main December 9, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants