-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update value of Mission.Summary.RANGE for fallout missions #630
base: main
Are you sure you want to change the base?
Conversation
@jkirk5 @Kenneth-T-Moore: This is because in 'main' the Mission.Summary.Range value is simply overwritten with the 'Target Range' value, which is just incorrect it doesn't actually tell you anything about the values output from the optimizer on how far that aircraft has actually flown . I don't know much about the shooting method and so I'm not sure why the range residual hasn't converged to zero in either case. This probably needs to be investigated further, but perhaps as a separate issue. For now what are your thoughts on updating the assert near equal value to 3765.48? |
…t error in test execution
@@ -212,7 +212,7 @@ def test_bench_GwGm_shooting(self): | |||
) | |||
|
|||
assert_near_equal( | |||
prob.get_val(Mission.Summary.RANGE, units='NM'), 3675.0, tolerance=rtol | |||
prob.get_val(Mission.Summary.RANGE, units='NM'), 3765.48, tolerance=rtol | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is annoying. mission:design:range is 3675,NM, no target_range is set anywhere, default cruise range is being set to mission:design:range, which is an ok first guess but still wrong, and to cap it all off, run_driver is false, so no optimization is actually run.
Summary
This PR makes some changes to methods for level 2 to remove the variable "actual_range" and replace it with Mission.Summary.RANGE
This is particularly helpful for fallout missions where this value was not being updated as expected.
Related Issues
None
Backwards incompatibilities
None
New Dependencies
None