Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set mass default #640

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Set mass default #640

wants to merge 25 commits into from

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Jan 7, 2025 •
edited
Loading

Summary

In this PR,

  • Functions add_aviary_input/add_aviary_output set value to 0.0 if there is no metadata default value.
  • Default values are set to 0.0 in variable_meta_data.py for variables used by mass subsystems.
  • In all components of geometry subsystem, val argument is removed from add_aviary_input/add_aviary_output calls.
    • Example: add_aviary_input(self, Aircraft.WING.HIGH_LIFT_MASS)
  • One concern remains: there are many inputs that are internally defined. Example: self.add_input("vel_c",...) in design_load.py. They are not touched.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang marked this pull request as draft January 7, 2025 20:10
xjjiang and others added 18 commits January 7, 2025 12:54
@xjjiang
Merge branch 'main' into set_mass_default
e369a5c
@xjjiang
set Aircraft.Engine.MASS_SCALER = 0 instead of 1 because that is in t…
33e4a5a 
…he unit test.
@xjjiang
minor update
0ae58a4
@xjjiang
removed new addition of Aircraft.Strut.MASS_COEFFICIENT setting becau…
3b16570 
…se it caused compilation error.
@xjjiang
added missing variable Aircraft.Engine.ADDITIONAL_MASS_FRACTION = 0.14.
7487d40
@xjjiang
keep shape=None in add_aviary_output()
7dc138b
@xjjiang
add Aircraft.Wing.SLAT_SPAN_RATIO and Aircraft.Wing.SLAT_CHORD_RATIO …
8100368 
…to PreMissionTestCase
@xjjiang
autopep8
c28aabe
@xjjiang
autopep8
c8023de
@xjjiang
set Aircraft.Engine.ADDITIONAL_MASS_FRACTIO = val=np.full(num_engine_…
b96194b 
…type, 0.14)
@xjjiang
Merge branch 'OpenMDAO:main' into set_mass_default
9149728
@xjjiang
minor update
69a97f5
@xjjiang
add aircraft:wing:slat_span_ratio
c0f388b
@xjjiang
remove temperary comments
e8616ad
@xjjiang
remove a few vals
225f641
@xjjiang
remove val from Aircraft.Fuel.DENSITY but keep the units because ther…
5c66d12 
…e are two different units in four components
@xjjiang
set ASPECT_RATIO to 0.0
a1d6fd6
@xjjiang
set Aircraft.HorizontalTail.TAPER_RATIO = 0.0
7d36dd0
@xjjiang xjjiang changed the title Set mass default (draft) Set mass default Jan 13, 2025
@xjjiang xjjiang marked this pull request as ready for review January 13, 2025 17:46
@jkirk5 jkirk5 self-requested a review January 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkirk5 jkirk5 Awaiting requested review from jkirk5

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xjjiang