Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project list on web site #24

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Project list on web site #24

merged 7 commits into from
Sep 18, 2024

Conversation

cornelius
Copy link
Member

No description provided.

data/projects.yml Outdated Show resolved Hide resolved
@cornelius cornelius requested a review from mxmehl August 29, 2024 14:55
@cornelius cornelius marked this pull request as ready for review August 29, 2024 15:10
Copy link
Member

@mxmehl mxmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! I have a few suggestions.

Generally, I wonder whether the projects would better fit on a separate page. For now, it's OKish, but for a better overview and to allow for more background text and links (from the TC, mainly) a separate page seems fair.

data/projects.yml Outdated Show resolved Hide resolved
data/projects.yml Outdated Show resolved Hide resolved
data/projects.yml Outdated Show resolved Hide resolved
@cornelius cornelius requested a review from mxmehl September 18, 2024 08:32
@cornelius
Copy link
Member Author

Generally, I wonder whether the projects would better fit on a separate page. For now, it's OKish, but for a better overview and to allow for more background text and links (from the TC, mainly) a separate page seems fair.

Agreed. I would keep it on the front page for now, but move to a separate page soon, when we are adding more projects. Same for the members.

Copy link
Member

@mxmehl mxmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

I've rebased and added two commits with cosmetic improvements

@mxmehl mxmehl merged commit 22108d3 into main Sep 18, 2024
3 checks passed
@mxmehl mxmehl deleted the project-list branch September 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants