Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use module Gallery without Deface #475

Merged

Conversation

Quentinchampenois
Copy link
Contributor

🎩 Description

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to organization settings
  • See ...

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (646f270) 89.34% compared to head (f49de8b) 89.34%.

❗ Current head f49de8b differs from pull request most recent head c081c02. Consider uploading reports for the commit c081c02 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/add_gallery_module_0.27     #475   +/-   ##
================================================================
  Coverage                            89.34%   89.34%           
================================================================
  Files                                   65       65           
  Lines                                 1595     1595           
================================================================
  Hits                                  1425     1425           
  Misses                                 170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review January 19, 2024 17:21
@Quentinchampenois Quentinchampenois merged commit 8b6d03f into feature/add_gallery_module_0.27 Jan 19, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/module-gallery-0.27 branch January 19, 2024 17:22
Quentinchampenois added a commit that referenced this pull request Jan 22, 2024
* feat: Add module gallery to 0.27

* fix: Add require false to decidim-gallery

* lint: Fix rubocop offenses

* fix: reactivate decidim-gallery

* fix: Use module Gallery without Deface (#475)

* fix: Use module Gallery without Deface

* fix: allow to deactivate Deface on dev mode

* fix: Fix bundler version

* fix: Add x86_64-linux support in Gemfile.lock

---------

Co-authored-by: Pauline Bessoles <[email protected]>
Co-authored-by: quentinchampenois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant