Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install decidim-budget_category_voting gem #513

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Apr 2, 2024

🎩 Description

This PR installs the decidim-budget_category_voting gem into decidim-app. Additionally, i had to fix:

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to organization settings
  • See ...

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (bd14241) to head (7ad7301).

❗ Current head 7ad7301 differs from pull request most recent head e4960f5. Consider uploading reports for the commit e4960f5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #513   +/-   ##
========================================
  Coverage    89.51%   89.51%           
========================================
  Files           68       68           
  Lines         1622     1622           
========================================
  Hits          1452     1452           
  Misses         170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecslupu alecslupu force-pushed the chore/category-budgets branch from 41787c4 to f01544f Compare April 4, 2024 06:06
@alecslupu alecslupu marked this pull request as ready for review April 4, 2024 17:42
@alecslupu alecslupu changed the title Decidim upgrade Install decidim-budget_category_voting gem Apr 4, 2024
@Quentinchampenois Quentinchampenois requested review from luciegrau, a team and AyakorK and removed request for a team April 9, 2024 10:09
AyakorK
AyakorK previously approved these changes Apr 9, 2024
@AyakorK AyakorK self-requested a review April 18, 2024 10:27
@luciegrau luciegrau merged commit 2b572d7 into develop Apr 18, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the chore/category-budgets branch April 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants