Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable Email from Extended Authorization Handler form #77

Closed
wants to merge 2 commits into from
Closed

feat: Disable Email from Extended Authorization Handler form #77

wants to merge 2 commits into from

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Nov 30, 2023

🎩 Description

Disabling of the email field that was asked to be removed

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Go to your profile
  • Go to authorizations
  • Click on "Additional Informations"
  • Verify that there is no longer the field email
  • Try to fill in the form
  • Check if there is no error

Tasks

  • Override the form to get rid of email field
  • Override the service to get rid of email mandatory
  • Add services specs to check if it still works
  • Add system specs to check the removal of the field email on the page and that it causes no error

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@AyakorK AyakorK marked this pull request as ready for review November 30, 2023 13:59
@AyakorK AyakorK requested review from Quentinchampenois, luciegrau and a team November 30, 2023 13:59
Quentinchampenois
Quentinchampenois approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Waiting news before merge

@Quentinchampenois
Copy link
Contributor

No more needed, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciegrau luciegrau luciegrau approved these changes

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyakorK @Quentinchampenois @luciegrau