feat: Modules simple proposals & paper ballots #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentinchampenois
requested review from
simonaszilinskas,
BarbaraOliveira13 and
a team
BarbaraOliveira13
requested changes
Jun 12, 2024
* feat: Add module paper ballots * chore: Update README and schema.rb * lint: Fix rubocop offenses
Quentinchampenois
changed the title
simonaszilinskas
requested changes
Jun 12, 2024
|
Hello @BarbaraOliveira13, thank you for the review, I confirm checkboxes were not present, this is now fixed 👍 @simonaszilinskas thank you for the review, I confirm the behaviour present in your video, I think this is also present in the simple_proposals module, maybe we should confirm and fix it there. See screenshot : |
moustachu
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix: Add simple proposals * lint: Fix rubocop offenses * fix: Select first photo in proposal form * test: Add Custom proposals factories * fix: Downgrade to decidim v0.27.5 * chore: Update db schema.rb * fix: Add simple proposals migration * chore: Update db schema.rb * revert: Gemfile locked to 0.27.5 * ci: Add x86_64 linux support * test: Fix proposal fields in system specs * test: Fix simple proposal system specs * test: Remove broken specs * test: Remove broken specs * test: Category id is optional * bump: Module simple proposal * feat: Module paper ballots (#83) * feat: Add module paper ballots * chore: Update README and schema.rb * lint: Fix rubocop offenses
Quentinchampenois
added a commit
that referenced
this pull request
Oct 9, 2024
* fix: Modify default proposal states (#77) * feat: Addition of Extra User Fields Module (#79) * feat: Add Extra User Fields * lint: Rubocop Fixes * feat: Add Friendly Signup (#78) * feat: Add friendly signup * feat: Add configurable options to the config * fix: Fix some tests and add new ones * fix: Missing text modification * chore: Merge Extra user fields --------- Co-authored-by: quentinchampenois <[email protected]> * feat: Add module budget booth (#81) * feat: Add module budget booth * bump: modules * ci: Add x86_64 linux support * test: Explore projects index * feat: Modules simple proposals & paper ballots (#82) * fix: Add simple proposals * lint: Fix rubocop offenses * fix: Select first photo in proposal form * test: Add Custom proposals factories * fix: Downgrade to decidim v0.27.5 * chore: Update db schema.rb * fix: Add simple proposals migration * chore: Update db schema.rb * revert: Gemfile locked to 0.27.5 * ci: Add x86_64 linux support * test: Fix proposal fields in system specs * test: Fix simple proposal system specs * test: Remove broken specs * test: Remove broken specs * test: Category id is optional * bump: Module simple proposal * feat: Module paper ballots (#83) * feat: Add module paper ballots * chore: Update README and schema.rb * lint: Fix rubocop offenses * feat: Add module budgets_importer (#84) * feat:module_budgets_importer * feat:budgets_importer add/bumb rspec * delete rspec --------- Co-authored-by: Quentin Champenois <[email protected]> * fix: Override budgets importer projects index * fix: incompat paper ballots and budgets importer * ci: ignore missing locales * fix: add french translation key for paper_ballot module (#88) * fix:budget_importer (#89) * bump: Bump of simple proposal module (#90) * fix: Change branch of simple proposal module * fix: Bump simple proposal module * fix: Downgrade wicked pdf (#91) * chore: Update docker compose command * fix(config): Force Rack attack to false * Upgrade decidim-custom_proposal_states (#92) * Update awesome with private fields (#93) * update awesome with private fields * use merged branch * fix: migration FixReferenceForAllResources when table does not exists * bump fix notifications and mails send after voting (#96) * Bump: simple_proposal update (#97) * Bump: simple_proposal update * test: update system test * Fix: Bump Decidim Awesome module (#95) * Fix export dropdown in admin proposals index (#98) * fix: add missing translation keys * test: update config file after i18n test * Bump simple proposal module (#100) * fix: Add missing Sidekiq queues (#101) * fix(sidekiq): duplicate sidekiq queue (#102) The queue `user_report` is duplicated --------- Co-authored-by: Guillaume MORET <[email protected]> Co-authored-by: ’Barbara Oliveira <[email protected]> Co-authored-by: Lucie Grau <[email protected]> Co-authored-by: Alexandru Emil Lupu <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: moustachu <[email protected]> Co-authored-by: stephanierousset <[email protected]>
Quentinchampenois
added a commit
that referenced
this pull request
Oct 10, 2024
* fix: Modify default proposal states (#77) * feat: Addition of Extra User Fields Module (#79) * feat: Add Extra User Fields * lint: Rubocop Fixes * feat: Add Friendly Signup (#78) * feat: Add friendly signup * feat: Add configurable options to the config * fix: Fix some tests and add new ones * fix: Missing text modification * chore: Merge Extra user fields --------- Co-authored-by: quentinchampenois <[email protected]> * feat: Add module budget booth (#81) * feat: Add module budget booth * bump: modules * ci: Add x86_64 linux support * test: Explore projects index * feat: Modules simple proposals & paper ballots (#82) * fix: Add simple proposals * lint: Fix rubocop offenses * fix: Select first photo in proposal form * test: Add Custom proposals factories * fix: Downgrade to decidim v0.27.5 * chore: Update db schema.rb * fix: Add simple proposals migration * chore: Update db schema.rb * revert: Gemfile locked to 0.27.5 * ci: Add x86_64 linux support * test: Fix proposal fields in system specs * test: Fix simple proposal system specs * test: Remove broken specs * test: Remove broken specs * test: Category id is optional * bump: Module simple proposal * feat: Module paper ballots (#83) * feat: Add module paper ballots * chore: Update README and schema.rb * lint: Fix rubocop offenses * feat: Add module budgets_importer (#84) * feat:module_budgets_importer * feat:budgets_importer add/bumb rspec * delete rspec --------- Co-authored-by: Quentin Champenois <[email protected]> * fix: Override budgets importer projects index * fix: incompat paper ballots and budgets importer * ci: ignore missing locales * fix: add french translation key for paper_ballot module (#88) * fix:budget_importer (#89) * bump: Bump of simple proposal module (#90) * fix: Change branch of simple proposal module * fix: Bump simple proposal module * fix: Downgrade wicked pdf (#91) * chore: Update docker compose command * fix(config): Force Rack attack to false * Upgrade decidim-custom_proposal_states (#92) * Update awesome with private fields (#93) * update awesome with private fields * use merged branch * fix: migration FixReferenceForAllResources when table does not exists * bump fix notifications and mails send after voting (#96) * Bump: simple_proposal update (#97) * Bump: simple_proposal update * test: update system test * Fix: Bump Decidim Awesome module (#95) * Fix export dropdown in admin proposals index (#98) * fix: add missing translation keys * test: update config file after i18n test * Bump simple proposal module (#100) * fix: Add missing Sidekiq queues (#101) * fix(sidekiq): duplicate sidekiq queue (#102) The queue `user_report` is duplicated * chore: Push version v0.4.1 --------- Co-authored-by: Guillaume MORET <[email protected]> Co-authored-by: ’Barbara Oliveira <[email protected]> Co-authored-by: Lucie Grau <[email protected]> Co-authored-by: Alexandru Emil Lupu <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: moustachu <[email protected]> Co-authored-by: stephanierousset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Description
Please describe your pull request.