-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/email format #41
Merged
Merged
Fix/email format #41
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c82e48f
fix:format email add-validators
BarbaraOliveira13 6847909
add validation with registration_form
BarbaraOliveira13 3b940bf
refacto
BarbaraOliveira13 89383aa
refacto
BarbaraOliveira13 5a038ee
add spec
BarbaraOliveira13 2483fff
Optimize the regex for better performance
BarbaraOliveira13 a46c261
add test for email with unvalid charact
BarbaraOliveira13 e4e9729
lint
BarbaraOliveira13 413ccca
Bump version to 0.4.6
BarbaraOliveira13 20ac0c1
add gemfile.lock
BarbaraOliveira13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
app/forms/concerns/decidim/friendly_signup/registration_form_override.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# frozen_string_literal: true | ||
|
||
module Decidim | ||
module FriendlySignup | ||
class RegistrationFormOverride < Decidim::RegistrationForm | ||
validate :no_special_characters_in_email | ||
|
||
private | ||
|
||
EMAIL_REGEX = /\A[^<>"']+@[a-zA-Z0-9\-.]+\.[a-zA-Z]{2,}/ | ||
|
||
def no_special_characters_in_email | ||
errors.add(:email, :invalid) if email =~ EMAIL_REGEX | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, we will need to find a way to make it "automatic" so we don't have to change it on every pull request but for now it's good !