Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposals filter default order #6

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented Aug 27, 2024

🎩 Description
This removes a no more necessary method that replaced the proposals filter default order chosen by admin with "recent".

📌 Related Issues
Notion card

Testing

  1. As an admin, go to a process
  2. Go to the configuration of proposals component
  3. Select in the "Default proposal sorting" , the "Default" value and update
  4. Go to the process public page, go to proposals and see that the Order by filter is set to "Random" (which correspond to the default value, cf screenshot), and not "Recent"
  5. As an admin, change the value of the "Default proposal sorting" and update
  6. See in the public page that the filter is now set to the new value

Screenshot
Capture d’écran 2024-08-27 à 10 34 00

@Stef-Rousset Stef-Rousset marked this pull request as ready for review August 27, 2024 08:52
Copy link

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally and it works, thank you!

@luciegrau luciegrau merged commit 63f67e7 into release/0.27-stable Aug 28, 2024
4 checks passed
@luciegrau luciegrau deleted the fix/proposals_default_order branch August 28, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants