Fix deleted user error in schema (decidim#13681)

* Fix deleted user error in schema

* Fix failing specs

* Remove method override

* Refactor

* Fix specs

* Refactor page serializer

* Fix specs on meetings and proposals

* Add specs for blogs and debates

* Fix debates spec

* Fix spec

decidim-accountability/lib/decidim/accountability/result_serializer.rb

@@ -50,10 +50,6 @@ def serialize
       attr_reader :result
       alias resource result
 
-      def component
-        result.component
-      end
-
       def proposals
         result.linked_resources(:proposals, "included_proposals").map do |proposal|
           Decidim::ResourceLocatorPresenter.new(proposal).url

decidim-blogs/lib/decidim/blogs/post_serializer.rb

@@ -42,10 +42,6 @@ def serialize
       attr_reader :post
       alias resource post
 
-      def component
-        post.component
-      end
-
       def url
         Decidim::ResourceLocatorPresenter.new(post).url
       end
@@ -69,20 +65,6 @@ def author_url(author)
           root_url # is a Decidim::Organization
         end
       end
-
-      def profile_url(author)
-        return "" if author.respond_to?(:deleted?) && author.deleted?
-
-        Decidim::Core::Engine.routes.url_helpers.profile_url(author.nickname, host:)
-      end
-
-      def root_url
-        Decidim::Core::Engine.routes.url_helpers.root_url(host:)
-      end
-
-      def host
-        resource.organization.host
-      end
     end
   end
 end

decidim-blogs/lib/decidim/blogs/schema_org_blog_posting_post_serializer.rb

@@ -32,6 +32,7 @@ def serialize
       private
 
       attr_reader :post
+      alias resource post
 
       def author
         case post.author.class.name
@@ -48,7 +49,7 @@ def author_user_group
         {
           "@type": "Organization",
           name: post.author.name,
-          url: EngineRouter.new("decidim", router_options).profile_url(post.author.nickname)
+          url: profile_url(post.author)
         }
       end
 
@@ -64,7 +65,7 @@ def author_user
         {
           "@type": "Person",
           name: decidim_escape_translated(post.author.name),
-          url: EngineRouter.new("decidim", router_options).profile_url(post.author.nickname)
+          url: profile_url(post.author)
         }
       end
 

decidim-blogs/spec/lib/decidim/blogs/post_serializer_spec.rb

@@ -23,10 +23,8 @@ module Blogs
 
         describe "author" do
           context "when it is a user" do
-            before do
-              post.author.update!(name: "John Doe")
-              post.reload
-            end
+            let(:author) { create(:user, name: "John Doe", organization: component.organization) }
+            let!(:post) { create(:post, component:, author:) }
 
             it "serializes the user name" do
               expect(serialized[:author]).to include(name: "John Doe")
@@ -35,6 +33,23 @@ module Blogs
             it "serializes the link to its profile" do
               expect(serialized[:author]).to include(url: profile_url(post.author.nickname))
             end
+
+            context "when author is deleted" do
+              let(:author) { create(:user, :deleted, organization: component.organization) }
+              let!(:debate) { create(:post, component:, author:) }
+
+              it "serializes the user id" do
+                expect(serialized[:author]).to include(id: author.id)
+              end
+
+              it "serializes the user name" do
+                expect(serialized[:author]).to include(name: "")
+              end
+
+              it "serializes the link to its profile" do
+                expect(serialized[:author]).to include(url: "")
+              end
+            end
           end
 
           context "when it is a user group" do
@@ -91,7 +106,7 @@ module Blogs
       end
 
       def profile_url(nickname)
-        Decidim::Core::Engine.routes.url_helpers.profile_url(nickname, host:)
+        Decidim::Core::Engine.routes.url_helpers.profile_url(nickname, host:, port: Capybara.server_port)
       end
 
       def root_url

decidim-blogs/spec/lib/decidim/blogs/schema_org_blog_posting_post_serializer_spec.rb

@@ -72,6 +72,16 @@ module Decidim::Blogs
             expect(serialized[:author][:name]).to eq(post.author.name)
             expect(serialized[:author][:url]).to eq("http://#{organization.host}:#{Capybara.server_port}/profiles/#{post.author.nickname}")
           end
+
+          context "when author is deleted" do
+            let(:author) { create(:user, :deleted, organization:) }
+
+            it "serializes the author" do
+              expect(serialized[:author][:@type]).to eq("Person")
+              expect(serialized[:author][:name]).to eq(post.author.name)
+              expect(serialized[:author][:url]).to eq("")
+            end
+          end
         end
 
         context "with user group author" do

decidim-blogs/spec/system/explore_posts_spec.rb

@@ -107,6 +107,14 @@
             expect(page).to have_content(user.name)
           end
         end
+
+        context "when participant is deleted" do
+          let(:author) { create(:user, :deleted, organization: component.organization) }
+
+          it "successfully shows the page" do
+            expect(page).to have_content("Deleted participant")
+          end
+        end
       end
 
       it "show post info" do

decidim-budgets/lib/decidim/budgets/project_serializer.rb

@@ -51,10 +51,6 @@ def serialize
       attr_reader :project
       alias resource project
 
-      def component
-        project.component
-      end
-
       def related_proposals
         project.linked_resources(:proposals, "included_proposals").map(&:id)
       end

decidim-core/app/serializers/decidim/exporters/serializer.rb

@@ -55,7 +55,23 @@ def event_name
         ActiveSupport::Inflector.underscore(self.class.to_s).sub("/", ".serialize.").gsub("/", ".")
       end
 
-      private
+      protected
+
+      delegate :component, to: :resource
+
+      def profile_url(user)
+        return "" if user.respond_to?(:deleted?) && user.deleted?
+
+        EngineRouter.new("decidim", { host: }).profile_url(user.nickname)
+      end
+
+      def root_url
+        Decidim::Core::Engine.routes.url_helpers.root_url(host:)
+      end
+
+      def host
+        resource.organization.host
+      end
 
       # helper method to serialize taxonomies for any resource
       def taxonomies

decidim-debates/lib/decidim/debates/debate_serializer.rb

@@ -64,10 +64,6 @@ def last_comment_by_fields
         }
       end
 
-      def component
-        debate.component
-      end
-
       def url
         Decidim::ResourceLocatorPresenter.new(debate).url
       end
@@ -91,20 +87,6 @@ def user_url(author)
           root_url # is a Decidim::Organization
         end
       end
-
-      def profile_url(author)
-        return "" if author.respond_to?(:deleted?) && author.deleted?
-
-        Decidim::Core::Engine.routes.url_helpers.profile_url(author.nickname, host:)
-      end
-
-      def root_url
-        Decidim::Core::Engine.routes.url_helpers.root_url(host:)
-      end
-
-      def host
-        resource.organization.host
-      end
     end
   end
 end

decidim-debates/spec/lib/decidim/debates/debate_serializer_spec.rb

@@ -52,12 +52,9 @@ module Debates
           end
 
           context "when it is a user" do
-            let!(:debate) { create(:debate, :participant_author) }
-
-            before do
-              debate.author.update!(name: "John Doe")
-              debate.reload
-            end
+            let(:author) { create(:user, name: "John Doe", organization: component.organization) }
+            let(:component) { create(:debates_component) }
+            let!(:debate) { create(:debate, component:, author:) }
 
             it "serializes the user name" do
               expect(serialized[:author]).to include(name: "John Doe")
@@ -66,6 +63,23 @@ module Debates
             it "serializes the link to its profile" do
               expect(serialized[:author]).to include(url: profile_url(debate.author.nickname))
             end
+
+            context "when author is deleted" do
+              let(:author) { create(:user, :deleted, organization: component.organization) }
+              let!(:debate) { create(:debate, component:, author:) }
+
+              it "serializes the user id" do
+                expect(serialized[:author]).to include(id: author.id)
+              end
+
+              it "serializes the user name" do
+                expect(serialized[:author]).to include(name: "")
+              end
+
+              it "serializes the link to its profile" do
+                expect(serialized[:author]).to include(url: "")
+              end
+            end
           end
 
           context "when it is a user group" do
@@ -208,7 +222,7 @@ module Debates
       end
 
       def profile_url(nickname)
-        Decidim::Core::Engine.routes.url_helpers.profile_url(nickname, host:)
+        Decidim::Core::Engine.routes.url_helpers.profile_url(nickname, host:, port: Capybara.server_port)
       end
 
       def root_url

decidim-debates/spec/system/show_spec.rb

@@ -53,6 +53,15 @@
 
       it { expect(page).to have_no_selector("iframe") }
     end
+
+    context "when participant is deleted" do
+      let(:author) { create(:user, :deleted, organization: component.organization) }
+      let!(:debate) { create(:debate, component:, author:) }
+
+      it "successfully shows the page" do
+        expect(page).to have_content("Deleted participant")
+      end
+    end
   end
 
   context "when shows the debate component" do

decidim-meetings/lib/decidim/meetings/meeting_serializer.rb

@@ -73,24 +73,6 @@ def author_url(author)
         end
       end
 
-      def profile_url(author)
-        return "" if author.respond_to?(:deleted?) && author.deleted?
-
-        Decidim::Core::Engine.routes.url_helpers.profile_url(author.nickname, host:)
-      end
-
-      def root_url
-        Decidim::Core::Engine.routes.url_helpers.root_url(host:)
-      end
-
-      def host
-        resource.organization.host
-      end
-
-      def component
-        meeting.component
-      end
-
       def related_proposals
         meeting.linked_resources(:proposals, "proposals_from_meeting").map do |proposal|
           Decidim::ResourceLocatorPresenter.new(proposal).url

decidim-meetings/lib/decidim/meetings/schema_org_event_meeting_serializer.rb

@@ -37,6 +37,7 @@ def serialize
       private
 
       attr_reader :meeting
+      alias resource meeting
 
       def organizer
         return organizer_user_group if meeting.decidim_user_group_id?
@@ -53,7 +54,7 @@ def organizer_user_group
         {
           "@type": "Organization",
           name: meeting.author.name,
-          url: EngineRouter.new("decidim", router_options).profile_url(meeting.user_group.nickname)
+          url: profile_url(meeting.user_group)
         }
       end
 
@@ -69,7 +70,7 @@ def organizer_user
         {
           "@type": "Person",
           name: decidim_escape_translated(meeting.author.name),
-          url: EngineRouter.new("decidim", router_options).profile_url(meeting.author.nickname)
+          url: profile_url(meeting.author)
         }
       end
 

decidim-meetings/spec/lib/decidim/meetings/schema_org_event_meeting_serializer_spec.rb

@@ -73,6 +73,19 @@ module Decidim::Meetings
             expect(serialized[:organizer][:name]).to eq(meeting.author.name)
             expect(serialized[:organizer][:url]).to eq("http://#{organization.host}:#{Capybara.server_port}/profiles/#{meeting.author.nickname}")
           end
+
+          context "with deleted author" do
+            let(:organization) { create(:organization) }
+            let(:user) { create(:user, :deleted, organization:) }
+            let(:component) { create(:meeting_component, :published, organization:) }
+            let!(:meeting) { create(:meeting, :published, author: user.reload, component:, latitude:, longitude:) }
+
+            it "serializes the organizer" do
+              expect(serialized[:organizer][:@type]).to eq("Person")
+              expect(serialized[:organizer][:name]).to eq(meeting.author.name)
+              expect(serialized[:organizer][:url]).to eq("")
+            end
+          end
         end
 
         context "with user group author" do

decidim-meetings/spec/system/show_spec.rb

@@ -34,5 +34,14 @@
         expect(page).to have_content("HST")
       end
     end
+
+    context "when participant is deleted" do
+      let(:user) { create(:user, :deleted, organization:) }
+      let!(:meeting) { create(:meeting, :published, author: user.reload, component:) }
+
+      it "successfully shows the page" do
+        expect(page).to have_content("Deleted participant")
+      end
+    end
   end
 end

decidim-pages/lib/decidim/pages/page_serializer.rb

@@ -35,10 +35,6 @@ def serialize
       attr_reader :page
       alias resource page
 
-      def component
-        page.component
-      end
-
       def url
         Decidim::ResourceLocatorPresenter.new(page).url
       end
@@ -62,20 +58,6 @@ def author_url(author)
           root_url # is a Decidim::Organization
         end
       end
-
-      def profile_url(author)
-        return "" if author.respond_to?(:deleted?) && author.deleted?
-
-        Decidim::Core::Engine.routes.url_helpers.profile_url(author.nickname, host:)
-      end
-
-      def root_url
-        Decidim::Core::Engine.routes.url_helpers.root_url(host:)
-      end
-
-      def host
-        resource.organization.host
-      end
     end
   end
 end