Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide register button in conference when no registration types #1221

Merged

Conversation

Stef-Rousset
Copy link

🎩 What? Why?

📌 Related Issues

📋 Subtasks

  1. go to admin dashboard
  2. create a conference with registrations enabled and without registration_types
  3. publish the conference
  4. click on See conference button
  5. there is no register button

co-author @BarbaraOliveira13

📷 Screenshots (optional)

Description

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@Stef-Rousset Stef-Rousset marked this pull request as ready for review April 19, 2024 14:14
@Stef-Rousset Stef-Rousset merged commit 6f092fe into Fix/conference_registering Apr 19, 2024
42 of 43 checks passed
@Stef-Rousset Stef-Rousset deleted the Fix/conference_registering_specs branch April 19, 2024 14:15
Stef-Rousset added a commit that referenced this pull request May 21, 2024
…#12706)

* test:update conference registration system test

* test: add registration_types controller test

* fix: conference registration_types controller index

* correction after PR review

* fix: hide register button in conference when no registration types (#1221)

* fix: hide register button in conference when no registration types

* lint: add missing space in conference show view page

* fix: add has_published_registration_types? method to conference model

* fix: add rspec for has_published_registration_types? method

* lint: fix with rubocop

* refacto

* fix: update views and system tests after change request

* fix: update system spec after review

* style: update context sentences in system test (#1223)

---------

Co-authored-by: stephanie rousset <[email protected]>
Co-authored-by: stephanierousset <[email protected]>
Co-authored-by: Quentin Champenois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant