fixed conditional statement

OpenUpSA · May 11, 2021 · 5bbf7b9 · 5bbf7b9
1 parent 0705772
commit 5bbf7b9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/wazimap_ng/datasets/admin/forms/dataset_admin_form.py b/wazimap_ng/datasets/admin/forms/dataset_admin_form.py
@@ -12,9 +12,8 @@ def clean(self):
         profile = cleaned_data.get('profile', None)
         permission_type = cleaned_data.get('permission_type', None)
 
-        if not profile:
-            if permission_type == 'private':
-                raise forms.ValidationError('Profile should be set for private permissions.')
+        if permission_type == 'private' and profile is None:
+            raise forms.ValidationError('Profile should be set for private permissions.')
         return cleaned_data
 
     def __init__(self, *args, **kwargs):