Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(MemBlock): turn on dontTouch only when debugging #3792

Merged
merged 1 commit into from
Oct 29, 2024
Merged

refactor(MemBlock): turn on dontTouch only when debugging #3792

merged 1 commit into from
Oct 29, 2024

Conversation

Anzooooo
Copy link
Member

This will result in the delivery of clean generated code and may remove some of the pseudo-paths.

@Anzooooo Anzooooo marked this pull request as ready for review October 28, 2024 04:42
@Anzooooo Anzooooo requested a review from eastonman as a code owner October 28, 2024 05:11
@eastonman
Copy link
Member

We've merged an outdated PR this morning. Please wait for PR #3791 which fix the formatting issue.

@Anzooooo Anzooooo added the do not merge Do not merge this pull request label Oct 28, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: c9631d7

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c9631d7 1.928 0.450 2.699 1.191 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c3d62b6
a6da536 1.917 0.450 2.699 1.204 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
b3c3582 1.928 0.450 2.699 1.190 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
faf7d50 1.928 0.450 2.699 1.195 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
cf7d6b7 1.927 0.450 2.699 1.199 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

@Anzooooo Anzooooo requested a review from happy-lx as a code owner October 28, 2024 11:59
@Anzooooo
refactor(MemBlock): turn on dontTouch only when debugging
02c5538 
This will result in the delivery of clean generated code and may remove some of the pseudo-paths.
@Anzooooo Anzooooo removed the do not merge Do not merge this pull request label Oct 28, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 02c5538

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
02c5538 1.917 0.450 2.699 1.187 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
9a07878
c3d62b6 1.928 0.450 2.699 1.190 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
a6da536 1.917 0.450 2.699 1.204 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
b3c3582 1.928 0.450 2.699 1.190 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
faf7d50 1.928 0.450 2.699 1.195 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

@Tang-Haojin Tang-Haojin merged commit 189d8d0 into master Oct 29, 2024
9 checks passed
@Tang-Haojin Tang-Haojin deleted the wzz_dontTouch branch October 29, 2024 06:17
Anzooooo added a commit that referenced this pull request Oct 30, 2024
@Anzooooo
refactor(MemBlock): turn on dontTouch only when debugging (#3792)
bb66b2a 
This will result in the delivery of clean generated code and may remove
some of the pseudo-paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@good-circle good-circle good-circle approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@weidingliu weidingliu Awaiting requested review from weidingliu weidingliu is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

@eastonman eastonman Awaiting requested review from eastonman

@happy-lx happy-lx Awaiting requested review from happy-lx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Anzooooo @eastonman @XiangShanRobot @linjuanZ @good-circle @Tang-Haojin