Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): update copy, add tooltips #17343

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(protocol-designer): update copy, add tooltips #17343

merged 2 commits into from
Jan 24, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jan 24, 2025 •
edited
Loading

Overview

This PR fixes various small copy and style bugs in PD:

  1. adds subtext to select gripper page in onboarding
  2. remove quantity dropdown from absorbance reader in onboarding
  3. change copy for no gripper with absorbance reader timeline warning, and
  4. add logic for disabled tooltips for labware tab of decksetuptools

Closes AUTH-1348
Closes AUTH-1349
Closes AUTH-1351
Closes AUTH-1352
Closes AUTH-1353

Test Plan and Hands on Testing

  • walk through Flex onboarding flow, and verify subtext on gripper page. select "yes" for gripper
  • add absorbance reader module during onboarding and verify that no quantity option displays
  • after creating protocol, edit protocol and select starting deck state
  • select absorbance reader > edit hardware
  • hover over disabled 'labware' tab and verify correct tooltip shows
  • select trash > edit hardware
  • hover over disabled 'labware' tab and verify correct tooltip shows

Changelog

Review requests

Risk assessment

@ncdiehl11
fix(protocol-designer): update copy, add tooltips
26a9ec0 
This PR fixes various small copy and style bugs in PD. 1) adds subtext to select gripper page in onboarding, 2) remove quantity dropdown from absorbance reader in onboarding, 3) change copy for no gripper with absorbance reader timeline warning, and 4) add logic for disabled tooltips for labware tab of decksetuptools

Closes AUTH-1348, Closes AUTH-1349, Closes AUTH-1351, Closes AUTH-1353
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 24, 2025 19:54
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner January 24, 2025 19:54
@ncdiehl11 ncdiehl11 requested review from koji and jerader and removed request for a team January 24, 2025 19:54
@ncdiehl11 ncdiehl11 self-assigned this Jan 24, 2025
jerader
jerader approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment about removing plate reader from MOAM_MODULE_TYPES but otherwise lgtm

@ncdiehl11 ncdiehl11 merged commit 14f956d into edge Jan 24, 2025
14 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-copy branch January 24, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@koji koji Awaiting requested review from koji

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @jerader