Cleanup. #525
Closed
Cleanup. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any real reason for the imports being modified? |
that's just automatic in my ide is there a issue with it? |
added 3 commits
February 2, 2022 06:17
OpticFusion1
reviewed
Feb 2, 2022
| @@ -45,8 +46,8 @@ public void downloadAndConnect() { | |||
| try { | |||
| Files.copy(new URL(DATABASE_URL).openStream(), tempFile.toPath(), StandardCopyOption.REPLACE_EXISTING); | |||
| } catch (IOException e) { | |||
| Files.copy(Database.class.getResource("/database.db").openStream(), tempFile.toPath(), | |||
| StandardCopyOption.REPLACE_EXISTING); | |||
| Files.copy(Objects.requireNonNull(Database.class.getResource("/database.db")).openStream(), tempFile.toPath(), | |||
There was a problem hiding this comment.
This one's not needed actually. It'll throw an error if it doesn't exist either way, however it'll just be an IOException.
OpticFusion1
reviewed
Feb 2, 2022
| @@ -44,8 +45,8 @@ public LinuxNotifSender() { | |||
| libNotify = new DefaultJLibnotifyLoader().load(); | |||
| libNotify.init("AntiMalware"); | |||
| notificationImage = File.createTempFile("notificationImage", "").toPath(); | |||
| Files.copy(Main.class.getResource("/index.jpg").openStream(), notificationImage, | |||
| StandardCopyOption.REPLACE_EXISTING); | |||
| Files.copy(Objects.requireNonNull(Main.class.getResource("/index.jpg")).openStream(), notificationImage, | |||
There was a problem hiding this comment.
This will always exist, so checking if it's null doesn't make sense. I can't really think of a reason it wouldn't.
OpticFusion1
reviewed
Feb 2, 2022
| @@ -128,7 +128,7 @@ private void scanZip(Path zippedFile) { | |||
| try ( PrintWriter pw = new PrintWriter(file)) { | |||
| pw.write(zippedFile.toString()); | |||
| } | |||
| for (File foundDir : destination.listFiles()) { | |||
| for (File foundDir : Objects.requireNonNull(Objects.requireNonNull(destination.listFiles()))) { | |||
There was a problem hiding this comment.
I don't really see why this is needed? The destination folder is always created and iirc if there's no files in the directory nothing will happen
|
Yh I realized after I had to go so couldn't commit fix in time |
I'm against the requireNonNull movement.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorta fixes #446