generated from microsoft/AzureTRE-Deployment
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Lets Encrypt Fix #31
Open
JaimieWi
wants to merge
1
commit into
main
Choose a base branch
from
feature/lets_encrypt_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets Encrypt workflow
What is being addressed
Pull in change to Deployment Repo - microsoft/AzureTRE#3979
Fix Lets Encrypt workflow
How is this addressed
Pulled in description from above PR:
See details of issue, but in summary to fix the lets_encrypt.yml GitHub Action:
missing variable:
AZURE_ENVIRONMENT
values of the following variables were the wrong way around:
ARM_SUBSCRIPTION_ID
ARM_TENANT_ID
following variables needed passing in TF_VAR_varname form:
TERRAFORM_STATE_CONTAINER_NAME
MGMT_RESOURCE_GROUP_NAME
MGMT_STORAGE_ACCOUNT_NAME
In addition, the following minor changes were made: