Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinants of maternal and child undernutrition #10

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

AnitaMakori
Copy link
Contributor

No description provided.

Copy link
Member

@ernestguevarra ernestguevarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I like it and is what I was expecting. Well done. Keep it going along this way.

One change I will request is for lines 5 to 7 where you declare package dependencies, can you remove that from this R script and add those lines to the file called packages.R?

So, the idea here is that we are centralising the packages that we are making dependencies on on a single file.

As for the descriptive analysis or exploratory data analysis of the variables you are looking at, maybe focus more on creating really compelling plots that illustrate possible correlation/relationship between outcome variables and the predictors. I think that will be a good exercise for each member of the team to do i.e., each one doing a plot showing correlation/relationship between undernutrition and one predictor. This will be a good preliminary presentation before you show results of your regression models.

@ernestguevarra
Copy link
Member

Forgot to mention, I shifted the base branch to which your PR will merge to once approved. Once approved, this will be first merged to the sakura branch. And then from there, I will manage how we put all things together.

@ernestguevarra
Copy link
Member

Error in automated checks due to lme4 dependency not available on actions runner instead of an issue with your code/script. This is now being addressed in #12

Copy link
Contributor

@ihtm-bot ihtm-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please merge

@AnitaMakori AnitaMakori merged commit fca5c23 into sakura Feb 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants