Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register multiple ISMIP6 source_id entries (#103) #106

Conversation

durack1
Copy link
Collaborator

@durack1 durack1 commented Jul 19, 2020

Fix #103
Ref #101

src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
src/writeJson.py Outdated Show resolved Hide resolved
@durack1
Copy link
Collaborator Author

durack1 commented Jul 22, 2020

@geresie take a peek at https://github.com/PCMDI/input4MIPs-cmor-tables/pull/106/files#diff-1cda588ea26bdfb36f1725e1fa0ce8b1 which should then be in reasonable shape, aside from a couple of variable clarifications

@durack1 durack1 marked this pull request as draft July 22, 2020 16:41
@durack1
Copy link
Collaborator Author

durack1 commented Jul 22, 2020

@geresie if this looks good to you, then I will merge and you can use the revised tables for data writing

@durack1
Copy link
Collaborator Author

durack1 commented Jul 23, 2020

@geresie apologies for nagging, but could you take a peek at this, pointing out any issues and giving me an "approve" review? Then I can merge this and you can start writing your data.

@geresie
Copy link

geresie commented Jul 23, 2020

Thanks so much, Paul.

@durack1
Copy link
Collaborator Author

durack1 commented Jul 23, 2020

@geresie great, there was one clarification, the mrro* variable, I have listed mrroLi (see here) which may not be the CMIP5/6 variable that you are writing, so we might have one last tweak.

Once you have confirmed I will (tweak if required, and) merge this pull request (PR) and double check our tables to make sure that we have all the variables that you want to write (mrro is a land monthly Lmon variable, and we only have the Lday table defined in this repo (see here). I assume all data that you are writing is monthly?

Note, if you are using CMOR3.6.0 there were some tweaks required to the input files, as some variables that CMOR 3.6.0 is expecting were renamed, so we can tweak that and add the code that you are using to produce this ISMIP6 as another demo to the repo (see here)

@geresie
Copy link

geresie commented Jul 23, 2020

The data are yearly. Can we add it to Lyr?
Thanks

@durack1
Copy link
Collaborator Author

durack1 commented Jul 23, 2020

@geresie and mrro* which variable is it?

@geresie
Copy link

geresie commented Jul 23, 2020

mrro -- surface_runoff_flux
Our data we are trying to write are all yearly.

@durack1
Copy link
Collaborator Author

durack1 commented Jul 23, 2020

@geresie that is the mrros variable see here from the Lmon table, whereas total runoff mrro is defined here for the Lmon table.

I will open a new issue to generate an Lyr table and make sure that mrros is included.

Which tables are you pulling the other variables from? I have guessed below, please correct anything wrong

"acabf" IyrGre/IyrAnt see here for the IyrGre table
"evspsbl" Amon see here
"mrros" Lmon see here
"pr", Amon as for evspsbl
"sftflf" is this fixed or time invariant, in which case it would be the fx table
"so" Omon see here
"ts" Amon see here

Obviously if you are generating annual mean data, all these tables become annual/yearly: Ayr, Lyr, Oyr etc etc

@geresie
Copy link

geresie commented Jul 23, 2020

Yes, all those tables are correct.

@durack1
Copy link
Collaborator Author

durack1 commented Jul 23, 2020

@geresie perfect, I will pull this across into a new issue which will update the tables, hopefully this arvo

@durack1 durack1 marked this pull request as ready for review July 23, 2020 22:17
@durack1 durack1 merged commit 510e525 into master Jul 23, 2020
@durack1 durack1 deleted the issue103_durack1_RegisterMultipleISMIP6-NASA-GSFCSource_idEntries branch July 23, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register multiple ISMIP6 source_id entries
2 participants