-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register multiple ISMIP6 source_id entries (#103) #106
Register multiple ISMIP6 source_id entries (#103) #106
Conversation
@geresie take a peek at https://github.com/PCMDI/input4MIPs-cmor-tables/pull/106/files#diff-1cda588ea26bdfb36f1725e1fa0ce8b1 which should then be in reasonable shape, aside from a couple of variable clarifications |
@geresie if this looks good to you, then I will merge and you can use the revised tables for data writing |
@geresie apologies for nagging, but could you take a peek at this, pointing out any issues and giving me an "approve" review? Then I can merge this and you can start writing your data. |
Thanks so much, Paul. |
@geresie great, there was one clarification, the Once you have confirmed I will (tweak if required, and) merge this pull request (PR) and double check our tables to make sure that we have all the variables that you want to write ( Note, if you are using CMOR3.6.0 there were some tweaks required to the input files, as some variables that CMOR 3.6.0 is expecting were renamed, so we can tweak that and add the code that you are using to produce this ISMIP6 as another demo to the repo (see here) |
The data are yearly. Can we add it to Lyr? |
@geresie and |
mrro -- surface_runoff_flux |
@geresie that is the I will open a new issue to generate an Which tables are you pulling the other variables from? I have guessed below, please correct anything wrong "acabf" IyrGre/IyrAnt see here for the IyrGre table Obviously if you are generating annual mean data, all these tables become annual/yearly: Ayr, Lyr, Oyr etc etc |
Yes, all those tables are correct. |
@geresie perfect, I will pull this across into a new issue which will update the tables, hopefully this arvo |
Fix #103
Ref #101