Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ver2 MRI-JRA55-do-1-5-0 #113

Closed

Conversation

HiroyukiTsujino
Copy link
Contributor

Many thanks @durack1 for the updated tables (#111). My demos worked with CMOR3.6.0 as I intended after several edits. Is it possible to incorporate the following modifications?

  • In mriJRA55-do-input.json, "source_id" should be "MRI-JRA55-do-1-X-0" to be consistent with intput4MIPs_CV.json. (2nd commit).
  • Variables in JRA55-do use several kinds of distinct grids, so I think that it is not appropriate to give unique "grid", "grid_label", "nominal_resolution" to the entire dataset. Instead, I am giving "grid", "grid_label", and "nominal_resolution" to each variable in python scripts to generate CMORized files (e.g., demo/MRI-JMA-JRA55-do-1-5-0/runCmorAllWrite-1-5-0.py). Note that overwriting global_attributes with runCmorAllWrite-1-5-0.py was not possible for those defined by "input4MIPs_CV.json". So, in the 1st commit, I edited input4MIPs_source_id.json so that "grid", "grid_label", "nominal_resolution" entries are eventually dropped from intpu4MIPs_CV.json (perhaps by your processing). If this is acceptable, I would like to take this method.
  • In the 3rd commit, demo/MRI-JMA-JRA55-do-1-4-0/Tables/input4MIPs_CV.json has been corrected by hand. (i.e., "grid", "grid_label", "nominal_resolution" entries for *1-5-0 are dropped.)
  • In the 4th commit, I added demos that generate CMORized files for JRA55-do-v1.5.0, they indeed worked with CMOR 3.6.0. Note that contents of demo/MRI-JMA-JRA55-do-1-5-0/Tables are copied from demo/MRI-JMA-JRA55-do-1-4-0/Tables, including corrected input4MIPs_CV.json at the above (the 3rd) commit.

@durack1
Copy link
Collaborator

durack1 commented Sep 14, 2020

@HiroyukiTsujino I am closing this, as I hope all changes are now included in the #114

@durack1 durack1 closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants