Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable numpy version > 2.0 #444

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable numpy version > 2.0 #444

wants to merge 1 commit into from

Conversation

schuenke
Copy link
Collaborator

@schuenke schuenke commented Oct 17, 2024

Few more things to fix than expected...

Copy link
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms
   prewhiten_kspace.py161038%53–73
src/mrpro/algorithms/csm
   inati.py242017%33–67
   walsh.py161225%31–52
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%15, 48–49, 76
src/mrpro/algorithms/optimizers
   adam.py20195%69
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%51–71, 85
   IterativeSENSEReconstruction.py422345%77–78, 88–98, 113–124, 138–149
   Reconstruction.py512453%41, 53–55, 79–86, 103–114
src/mrpro/data
   AcqInfo.py128398%174, 206, 214
   CsmData.py281546%14, 39–51, 72–77, 81–83
   DcfData.py44882%17, 65, 77–82
   IData.py671381%69–70, 83–84, 119, 125, 129, 159–167
   IHeader.py75889%53, 75, 109, 127–131
   KHeader.py1643479%24, 126–130, 157, 186, 200, 203–207, 216, 218, 222–223, 225–226, 229, 232–236, 240, 243, 246, 260–267, 275–286
   KNoise.py311552%39–52, 56–61
   KTrajectory.py69297%160–163
   MoveDataMixin.py1261489%14, 109, 125, 139–141, 202, 265, 279, 358, 378–379, 396–397
   QData.py39977%36, 38, 42, 65–73
   QHeader.py27293%32, 43
   Rotation.py4472295%96, 277, 362, 364, 391, 446, 451, 454, 469, 486, 491, 634, 639, 642, 658, 662, 736, 738, 746–747, 987, 1069
   SpatialDimension.py46296%64, 103
   TrajectoryDescription.py14193%23
   acq_filters.py10190%47
src/mrpro/data/_kdata
   KData.py1051685%108–109, 118, 126, 180–181, 216, 221–222, 241–252
   KDataRearrangeMixin.py15753%29–43
   KDataRemoveOsMixin.py292224%38–75
   KDataSelectMixin.py201335%41–65
   KDataSplitMixin.py483723%46–112, 134, 156
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%23, 45
   KTrajectoryCartesian.py13654%27–36
   KTrajectoryIsmrmrd.py13285%41, 50
   KTrajectoryPulseq.py291934%27–29, 44–66
   KTrajectoryRpe.py301937%37–40, 69–80, 94, 108–110, 125–135
   KTrajectorySunflowerGoldenRpe.py251540%22–23, 46–58, 72, 86–93
src/mrpro/operators
   CartesianSamplingOp.py503726%41–72, 87–99, 113–142
   ConstraintsOp.py60297%46, 48
   EndomorphOperator.py51296%209, 213
   FiniteDifferenceOp.py27293%48, 113
   FourierOp.py775529%50, 57, 61–118, 131, 149–176, 190–214
   Functional.py43295%108, 110
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py131695%51, 87, 186, 253, 362, 367
   Operator.py52198%21
   SliceProjectionOp.py17312627%38–44, 52–54, 58–70, 155–156, 160–209, 224–241, 257–284, 295–317, 358–475
   WaveletOp.py120596%152, 170, 205, 210, 233
   ZeroPadOp.py16194%30
src/mrpro/phantoms
   coils.py20955%49–61
src/mrpro/utils
   filters.py62297%44, 49
   modify_acq_info.py17194%12
   slice_profiles.py451371%18, 34, 106–108, 111–114, 146–150
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py11373%21, 23, 25
   typing.py11736%6–15
   zero_pad_or_crop.py31681%26, 30, 54, 57, 60, 63
TOTAL383470982% 

Tests Skipped Failures Errors Time
1359 0 💤 89 ❌ 36 🔥 52.649s ⏱️

Copy link
Contributor

📚 Documentation

📁 Download as zip
🔍 View online

@schuenke
Copy link
Collaborator Author

ok, seems like I used a wrong env when I tested it locally and everything passed 🙄

I think we should still tackle this, but I won't be able to do it today. But we can also merge this PR after #439 ...

@schuenke schuenke marked this pull request as draft October 17, 2024 07:13
@fzimmermann89
Copy link
Member

Puh, too bad. This looks unfortunately like quite some detective work. Maybe put it on our to-do list for some time in the future..

@schuenke
Copy link
Collaborator Author

Quite funny actually: numpy/numpy#26620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants