-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apply_ to dataclasses #489
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
fzimmermann89
added a commit
that referenced
this pull request
Oct 28, 2024
📚 Documentation |
fzimmermann89
added a commit
that referenced
this pull request
Oct 28, 2024
fzimmermann89
added a commit
that referenced
this pull request
Oct 28, 2024
This might be moved outside the movedatamixin at some point, or the mixin will just become a baseclass for our datastuff. |
I think it would be a good idea to add a test which especially verifies the memo-functionality |
fzimmermann89
changed the base branch from
gh/fzimmermann89/27/orig
to
gh/fzimmermann89/28/orig
November 9, 2024 17:51
fzimmermann89
added a commit
that referenced
this pull request
Nov 10, 2024
fzimmermann89
added a commit
that referenced
this pull request
Nov 10, 2024
moved to #505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need an apply on our dataclasses, both for @ckolbPTB's work as well, and for the rearrangeind und indexing.
As the _to already basically does an recursive apply with memorization, this refactors it such that the _apply can also be used with different functions.