-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert NamedTemporaryFile ContextManager in example notebooks #500
Merged
+51
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚 Documentation |
fzimmermann89
force-pushed
the
revert-498-pre-commit-ci-update-config
branch
from
November 10, 2024 15:51
d4522d7
to
6a9aba9
Compare
fzimmermann89
approved these changes
Nov 10, 2024
fzimmermann89
changed the title
Revert "[pre-commit] pre-commit autoupdate"
Revert NamedTemporaryFile ContextManager in example notebooks
Nov 11, 2024
Thanks! Any objections to merging it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts changes to examples from #498 because we decided NOT to use a context manager to open the data files and just ignore the RUFF rule in our example notebooks.