Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colab badge to notebooks #501

Closed
wants to merge 24 commits into from
Closed

Add colab badge to notebooks #501

wants to merge 24 commits into from

Conversation

ckolbPTB
Copy link
Collaborator

@ckolbPTB ckolbPTB commented Nov 7, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms/csm
   inati.py24196%44
   walsh.py16194%34
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%15, 48–49, 76
src/mrpro/algorithms/optimizers
   adam.py20195%69
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%51–71, 85
   IterativeSENSEReconstruction.py13192%76
   Reconstruction.py502256%42, 54–56, 80–87, 104–113
   RegularizedIterativeSENSEReconstruction.py411759%96–100, 114–139
src/mrpro/data
   AcqInfo.py128398%26, 169, 207
   CsmData.py29390%15, 82–84
   DcfData.py45882%18, 66, 78–83
   IData.py67987%119, 125, 129, 159–167
   IHeader.py75791%75, 109, 127–131
   KHeader.py1531789%25, 119–123, 150, 199, 210, 217–218, 221, 228, 260–271
   KNoise.py311552%39–52, 56–61
   KTrajectory.py69593%178–182
   MoveDataMixin.py1401887%15, 113, 129, 143–145, 207, 323–325, 338, 417, 437–438, 440, 455–456, 458
   QData.py39782%42, 65–73
   Rotation.py6743595%100, 198, 335, 433, 477, 495, 581, 583, 592, 626, 628, 691, 768, 773, 776, 791, 808, 813, 889, 1077, 1082, 1085, 1109, 1113, 1240, 1242, 1250–1251, 1315, 1397, 1690, 1846, 1881, 1885, 1996
   SpatialDimension.py2322191%34, 104, 141, 148, 154, 274–276, 289–291, 325, 343, 356, 369, 382, 395, 404–405, 420, 429
   acq_filters.py12192%47
src/mrpro/data/_kdata
   KData.py1341887%109–110, 125, 132, 142, 150, 204–205, 243, 248–249, 268–279
   KDataRemoveOsMixin.py29293%44, 46
   KDataSelectMixin.py19289%48, 63
   KDataSplitMixin.py48394%53, 84, 93
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%23, 45
   KTrajectoryIsmrmrd.py13285%41, 50
   KTrajectoryPulseq.py31197%54
src/mrpro/operators
   CartesianSamplingOp.py89397%118, 157, 280
   ConstraintsOp.py60297%46, 48
   EndomorphOperator.py65297%228, 234
   FiniteDifferenceOp.py27293%40, 105
   FourierOp.py158398%263, 381, 386
   Functional.py71593%20–22, 117, 119
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py1681094%55, 91, 190, 220, 261, 270, 278, 287, 295, 320
   LinearOperatorMatrix.py1581690%82, 119, 152, 161, 166, 175–178, 191–194, 203, 215, 304, 331, 359
   MultiIdentityOp.py13285%43, 48
   Operator.py78297%25, 74
   ProximableFunctionalSeparableSum.py39392%50, 103, 110
   SliceProjectionOp.py173895%44, 61, 63, 69, 206, 227, 260, 300
   WaveletOp.py120596%152, 170, 205, 210, 233
   ZeroPadOp.py16194%30
src/mrpro/utils
   filters.py62297%44, 49
   reshape.py60198%191
   slice_profiles.py46687%20, 36, 113–116, 149
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py11918%20–29
   typing.py181139%8–23
   zero_pad_or_crop.py31681%26, 30, 54, 57, 60, 63
TOTAL491235393% 

Tests Skipped Failures Errors Time
2262 0 💤 0 ❌ 0 🔥 2m 9s ⏱️

@fzimmermann89
Copy link
Member

good idea!

maybe have a

try:
  import mrpro
except ImportError
   !pip install mrpro 
    import mrpro

or similar block at the beginning of ll example notebooks?

Copy link
Contributor

github-actions bot commented Nov 7, 2024

📚 Documentation

📁 Download as zip
🔍 View online

@fzimmermann89
Copy link
Member

have you considered writing one script that a) adds the cell and b) calls jupytext? I.e. added the conversion also to the script?
then we could call that script from pre-commit, with the mid-term goal enabling to see all changes to docu/examples also locally without relying on github actions..

@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Nov 7, 2024

Tried to add the

try:
  import mrpro
except ImportError
   !pip install mrpro 
    import mrpro

block but in the script it is invalid code and when I add it to the notebook during conversion it is detected as a modification to the notebook which leads to an endless loop of translating py to ipynb -> adding cell -> committing -> translating py ti ipynb -> adding cell -> committing...

@ckolbPTB ckolbPTB mentioned this pull request Dec 10, 2024
10 tasks
@lrlunin
Copy link
Collaborator

lrlunin commented Dec 11, 2024

Tried to add the

try:
  import mrpro
except ImportError
   !pip install mrpro 
    import mrpro

block but in the script it is invalid code and when I add it to the notebook during conversion it is detected as a modification to the notebook which leads to an endless loop of translating py to ipynb -> adding cell -> committing -> translating py ti ipynb -> adding cell -> committing...

I would add the following code cell in the .py files for the installation of mrpro package.

try:
    import mrpro
except ImportError:
    subprocess.check_call([sys.executable, "-m", "pip", "install", 'mrpro'])
finally:
    import mrpro

Unfortunetely it would not be enough only to add this to the notebooks in the docs since the google colab references to the github file representation.

@lrlunin
Copy link
Collaborator

lrlunin commented Dec 19, 2024

implemented in #537

@lrlunin lrlunin closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants