Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issue in SignatureBoxGroup class #117

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

microshine
Copy link
Contributor

@microshine microshine commented Jan 19, 2024

This pull request fixes a formatting issue in the SignatureBoxGroup class. It addresses the incorrect calculation of the byte range and ensures that the range of bytes points to the correct data. The changes include updates to the PDFDocumentUpdate class and the SignatureBoxGroup class.

The update inclueds tests for:

  • %%EOF with EOL should have valid state if EOL is:
    • 'empty'
    • '\n'
    • '\r\n'
    • '\n\n'
    • '\n\n\n'
    • should return invalid state if there are 'Too many bytes after %%EOF marker'
    • should return invalid state if there are 'EOL contains invalid characters'
    • should return invalid state if there are 'Document contains extra bytes after signed data'
  • ByteRange
    • should return invalid state if ByteRange[0] points to incorrect data
    • should return invalid state if ByteRange[1] points to incorrect data
    • should return invalid state if ByteRange[2] points to incorrect data

All possible endings of the update section in the PDF document, including '%%EOF\n', '%%EOF\n\n', and so on, have undergone thorough testing to ensure seamless integration with Acrobat Reader.

@microshine microshine merged commit 0f9aec4 into main Jan 19, 2024
@microshine microshine deleted the fix-formatting-state branch January 19, 2024 18:07
Copy link

NPM package v1.14.0 has been published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant