Anticipation Velocity Model (AVM) #1432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change is to make sure, I'm using my own version. - Will be reversed when I'm done
TODO: _JPS_Agent_GetCollisionFreeSpeedModelV3State can not be found when importing jupedsim
Ozaq
reviewed
Jan 1, 2025
chraibi
changed the title
chraibi
changed the title
|
@xuqiancheng I think the model is ready for your review. Can you please check if the equations are implemented correctly according to the model? We can not yet use the model though, due to lack of the python-API. |
xuqiancheng
reviewed
Jan 7, 2025
- Remove range_geometry and strength_geometry - Add new parameter wall_buffer_distance
- Change visualisation from grid to simple to fit the layout of documentation - remove dependency Remove requirement
|
@Ozaq I think most of the text in the first cell of the model-comparison-notebook, might be better placed in pedestrian_models/index.html. What do you think? I would do it directly in this PR. |
Ozaq
reviewed
Jan 15, 2025
CMakeLists.txt
Outdated
| @@ -2,7 +2,7 @@ | |||
| # Project setup | |||
| ################################################################################ | |||
| cmake_minimum_required(VERSION 3.22 FATAL_ERROR) | |||
| project(JuPedSim VERSION 1.3.0 LANGUAGES CXX) | |||
| project(JuPedSim VERSION 1.3.1 LANGUAGES CXX) | |||
There was a problem hiding this comment.
Please revert the version bump, 1.3.0 is still unreleased
Ozaq
reviewed
Jan 15, 2025
examples/example7_avm.py
Outdated
Comment on lines
29
to
30
| # geometry = shapely.GeometryCollection(shapely.box(0, -2.5, 50, 2.5)) | ||
| # exit_polygon = shapely.box(48, -2.5, 50, 2.5) # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the model Anticipation in a velocity-based model for pedestrian dynamics
is implemented.
AntiTime,ConstantAlpha