Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI and code #3

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Improve CLI and code #3

merged 3 commits into from
Jun 21, 2024

Conversation

ThePedroo
Copy link
Member

Changes

This PR adds improvements to the CLI, fixing segmentation fault when TMP_PATH variable was not set and adding a way to check for information about the daemon. Also improves the code by changing more C++ keywords to C keywords.

Why

This allows the WebUI to be possible, but also improves the stability of the project. C is also a faster and more efficient language than C++, which is necessary here.

Checkmarks

  • The modified functions have been tested.
  • Used the same indentation as the rest of the project.
  • Updated documentation (changelog).

This commit improves the CLI of ReZygisk, allowing the use of important information like PID of the daemons.
This commit improves the code of the project overall.
This commit improves the code overall by transpiling to C.
@ThePedroo ThePedroo requested a review from RainyXeon June 21, 2024 01:49
@ThePedroo ThePedroo assigned ThePedroo and unassigned ThePedroo Jun 21, 2024
@ThePedroo ThePedroo merged commit 678d886 into main Jun 21, 2024
1 check passed
@ThePedroo ThePedroo deleted the improve/code-and-cli branch June 23, 2024 02:17
@ThePedroo ThePedroo added confirmed This issue or pull request is confirmed to be done. enhancement New feature or request labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue or pull request is confirmed to be done. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants