Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix have_compiler when cross-compiling #411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fperrad
Copy link
Contributor

@fperrad fperrad commented Dec 29, 2021

the short cut introduced by the commit 5e55318 must depend on $Config{'usecrosscompile'}.

@mohawk2
Copy link
Member

mohawk2 commented Dec 29, 2021

This seems sensible.

@Leont
Copy link
Member

Leont commented Dec 29, 2021

Doesn't that reintroduce the issue that 5e55318 sought to fix for cross-compiling perls?

@Leont Leont requested a review from haarg December 29, 2021 21:03
the short cut introduced by the commit Perl-Toolchain-Gang@5e55318 must depend on `$Config{'usecrosscompile'}`.
@fperrad fperrad changed the title cross-compiling needs a real compiler check fix have_compiler when cross-compiling Dec 30, 2021
@fperrad
Copy link
Contributor Author

fperrad commented Dec 30, 2021

after comments from @Leont , I rewrite the patch in a saner way : the short cut always applies when PERL_CORE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants