Refactor tests #12
Open
Refactor tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentfredric
changed the title
kentfredric
force-pushed
the
test-refurbish
branch
3 times, most recently
from
7806eaf to
78ce16a
Compare
Note: The reason all those extra lines vanish ... is because that's how wide spread the side effects are of interwoven tests in this code.
kentfredric
force-pushed
the
test-refurbish
branch
4 times, most recently
from
de39eaa to
34e657d
Compare
kentfredric
force-pushed
the
test-refurbish
branch
from
34e657d to
1b6bdcb
Compare
- With typo fixes by mohawk. Closes #1
kentfredric
force-pushed
the
test-refurbish
branch
from
1b6bdcb to
0312722
Compare
kentfredric
force-pushed
the
test-refurbish
branch
from
0312722 to
86a6885
Compare
…t without side effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intentionally incomplete and just serves to make the work-in-progress more visible.
External dependencies are very limited on anything XS-like at present because we don't know what we can use, if anything, due to EUMM depending on us in some way some of the time, which may be a bootstrap problem when
EUMM -> EUM -> EUM.test -> Time::HiRes.configure -> EUMM
(And that might be a problem during perl bootstrap )
Either way, the tempdir consumption is expressly written such that
runtempruntempcan be implemented however we want it to beThe initial commit factors out tests specific to
mkmanifestinvocation and there is one remanining call in the main .t yet to be isolated ( Because I don't know where to put it, mostly ).Doing my best to migrate changes from
Manifest.tto the relevant test files in steps so its obvious that our test coverage stays the same as it was ( or better ).The new tests are going to be much larger by default due to the levels of isolation vs the existing one where every test is inextricably dependent on all the ones before it.