Apply color to STDERR instead of STDOUT on Win32 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output wasn't colored on Win32 because the colors were being applied to STDOUT but the text to color (especially failures) appears on STDERR.
rivy
added a commit
to rivy/perl.Test-Harness
that referenced
this pull request
Sep 11, 2016
+ rationale: using Win32::Console::ANSI simplifies the code and improves Win32 outputs - simplified usage ~ Win32::Console::ANSI is fire-and-forget - once loaded, use Term::ANSIColor without regard for platform - fixes incorrect color 'reset' behavior - Win32::Color::ANSI resets correctly to the prior default color attribute set - bug due to incorrect assumption that LIGHTGRAY on BLACK are always the default color attributes - fixes [GH#26](Perl-Toolchain-Gang#26) - Win32::Console::ANSI works for all output (no tie to a specific output handle) - [PR#34](Perl-Toolchain-Gang#34) is no longer needed
|
This change looks good to me. Let's merge it! |
Leont
pushed a commit
that referenced
this pull request
Jul 23, 2017
+ rationale: using Win32::Console::ANSI simplifies the code and improves Win32 outputs - simplified usage ~ Win32::Console::ANSI is fire-and-forget - once loaded, use Term::ANSIColor without regard for platform - fixes incorrect color 'reset' behavior - Win32::Color::ANSI resets correctly to the prior default color attribute set - bug due to incorrect assumption that LIGHTGRAY on BLACK are always the default color attributes - fixes [GH#26](#26) - Win32::Console::ANSI works for all output (no tie to a specific output handle) - [PR#34](#34) is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output wasn't colored on Win32 because the colors were being applied to STDOUT but the text to color (especially failures) appears on STDERR.