-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process raw TAP output from STDIN #83
base: master
Are you sure you want to change the base?
Conversation
But how to process TAP streams that don't start with |
Just read TAP13 specs. Looks like the |
TAP can start with:
I think that in that light a heuristic becomes quite fragile. |
lib/App/Prove/State.pm
Outdated
[#] # A comment | ||
| | ||
(?: | ||
1\.\.\d | # A plan line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be \d+
, otherwise it would fail to match 1..10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is only as good as tests. Good catch.
This seems like a fragile approach to me. I'd prefer the "parse stdin" mode to be enabled with a new option to |
Agreed |
An explicit option would be more robust. |
I was imagining the option would replace the heuristic parsing, rather than being an alternative to it. I think heuristic parsing of any sort is likely to cause problems, and Test::Harness risks being bound by backcompat with those problematic aspects. |
For #41.