Skip to content

Commit

Permalink
Add pre-commit in github test
Browse files Browse the repository at this point in the history
  • Loading branch information
FlorianWilhelm committed Nov 29, 2023
1 parent 984a031 commit 9bf58a4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Install Hatch
run: pip install --upgrade --pre hatch
- name: Install Hatch & pre-commit
run: pip install --upgrade --pre hatch pre-commit

- name: Lint
- name: Linting
if: matrix.python-version == '3.10' && runner.os == 'Linux'
run: hatch run lint:all

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,4 @@ To start this project off a lot of inspiration and code was taken from [Alexande
[tox]: https://tox.wiki/
[mypy]: https://mypy-lang.org/
[ruff]: https://github.com/astral-sh/ruff
[VS Code]: https://code.visualstudio.com/
2 changes: 1 addition & 1 deletion src/pytanis/pretalx/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def speakers_as_df(

def reviews_as_df(reviews: Iterable[Review]) -> pd.DataFrame:
"""Convert the reviews to a dataframe"""
df = pd.DataFrame([review.dict() for review in reviews])
df = pd.DataFrame([review.model_dump() for review in reviews])
# make first letter of column upper-case in accordance with our convention
df.rename(columns={col: col.title() for col in df.columns}, inplace=True)
# user is the speaker name to use for joining
Expand Down

0 comments on commit 9bf58a4

Please sign in to comment.