Сверстал страницу события #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontstall
changed the title
frontstall
changed the title
frontstall
requested review from
Realetive,
mike1pol and
strdmitriy
and removed request for
mike1pol
strdmitriy
reviewed
Jan 27, 2020
| return ( | ||
| <ul className="Tags"> | ||
| {data.map((name, i) => ( | ||
| <li key={i} className="Tags__Item"> |
There was a problem hiding this comment.
не используй индексы для ключей, как вариант${name}_${i}
https://ru.reactjs.org/docs/lists-and-keys.html
There was a problem hiding this comment.
все равно ключ будет завязан на индексе с теми же последствиями, как если использовать просто индекс. У нас пока нет других данных по тегам, на которые можно опереться, а имя тега может повторяться. Редактироваться теги в этом интерфейсе не могут, поэтому индекс в качестве ключа ок.
mike1pol
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 Страницу ещё нужно завернуть в лейаут с футером-хэдером, добавить завитушку и адаптировать под мобилки. Поправить реализацию списка участников, когда станет понятно, как будет он приходить - с пагинацией или без.
UPD: добавил завитушку