Autodesk: Android Proposal #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
requested changes
Aug 31, 2023
erikaharrison-adsk
force-pushed
the
adsk/feature/android
branch
from
644ae53 to
b817250
Compare
|
Changes are reflected in the proposal. @meshula Please advise what other questions you have. |
|
@meshula - any update on this? Thanks |
meshula
approved these changes
Feb 8, 2024
meshula
approved these changes
Feb 8, 2024
|
Hi Erika, the changes look good. Unfortunately one of the updated commits didn't have signing, so merging is blocked. Would it be possible to rewrite the commits with signing, and then we can land it? |
erikaharrison-adsk
force-pushed
the
adsk/feature/android
branch
from
b817250 to
542f861
Compare
|
Updated to verified commits. |
erikaharrison-adsk
pushed a commit
to autodesk-forks/USD-proposals
that referenced
this pull request
Apr 30, 2024
) Update the proposal according to the comments. We will focus on the schema in the proposal, not the implementation. So I removed the part about the Rprims, and also the plugins. Add more detail about the SimpleText and MarkupText schemas. Add how the extents should be implemented. Add the language tag for the textData in SimpleText and markup in MarkupText, and refer to the language proposal. Add the "plain" tag for markup which is an alternate string when the markup can not be identified. Remove the renderer property in SimpleText and MarkupText. Change the name of the properties in TextStyle. Add altTypeface property which is used when the main typeface can not support some characters. Add details about the font weight. The TextLayout and TextLayoutAPI are merged into one schema. The new TextLayoutAPI not only contains the character directions, but also contains the direction how the lines are stacked. Modify the name of the properties in ColumnStyle. Remove the direction and linesFlowDirection property in ColumnStyle. Instead, you can apply a TextLayoutAPI to a ColumnStyle to specify the directions. In the part of "Some implementation details", discuss the extrusion, the missing characters, the layout for complex script and the billboard. Finally there is a big part of four examples. <!-- Put screenshots or other summary information here --> <!-- Please review the [Contributing](https://graphics.pixar.com/usd/release/contributing_to_usd.html) page in the documentation for the Supplemental Terms that apply to this repository. Place an X in the box when you have reviewed and agree to the Supplemental Terms. --> - [ ] I agree to and accept the [Supplemental Terms](https://graphics.pixar.com/usd/release/contributing_supplemental.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Proposal
This is a proposal on supporting Android within OpenUSD.
Supporting Materials
N/A
Contributing