upd: kick notification on client side & fix: no kick option for local user #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: |
IntegratedQuantum
requested changes
Dec 9, 2024
|
@IntegratedQuantum as of now we have three possible "disconnect" reasons right?
|
somanshurath
changed the title
|
Yes. We could have more in the future though. |
IntegratedQuantum
requested changes
Dec 15, 2024
| shouldExitToMenu.store(true, .monotonic); | ||
| exitNotification.store(exitData, .monotonic); |
There was a problem hiding this comment.
Having two atomics like this is a problem.
The main thread could see the new value of shouldExitToMenu, but still see the old value of exitNotification, which causes a small chances of seeing an incorrect exit value.
Could you maybe just use one attomic of ?network.DisconnectType to cover both in one?
| @@ -21,6 +21,26 @@ const Vec3f = vec.Vec3f; | |||
| const Vec3i = vec.Vec3i; | |||
| const NeverFailingAllocator = main.utils.NeverFailingAllocator; | |||
|
|
|||
| pub const DisconnectType = enum(u8) { | |||
There was a problem hiding this comment.
I don't particularly like that this is just declared randomly at the beginning of the file.
Wouldn't it make more sense to move it into the disconnect protocol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: dont show kick for local user