-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added crouching and block based friction #926
Added crouching and block based friction #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should average the friction differently.
Also @ikabod-kee could you take a look at how these changes feel in-game?
I shall |
It feels good, though there are some changes I would make.
I have no complaints about the crouching as of yet. |
In fact, I love the sort of linear interpolation for crouching. Makes it feel very tactical. |
Okay, I have found a complaint for crouching, let me record it |
Crouching bug: |
Additionally, you cannot go up half-blocks while crouching, which can be an issue. |
Although maybe not, because jumping at the edge of it will snap you to its top |
I found another bug. You can no longer fly forward and down at the same time. |
Also friction affects the player in noclip when it shouldn't. |
8mb.video-9Or-svDkihw0.mp4The player should be able to fit in these holes |
It would also prevent the strange bounce when crouching in mid-air |
You should be able to step up slabs while crouching, especially since you can still walk down stairs while crouching. |
The player's hitbox is exactly 1.5 blocks tall when crouching so thats probably what makes that very hard. Should i shrink it to something like 1.45? |
Yes |
The recent changes look good. Here's some remaining issues:
|
Let me check out these fixes 👍 |
Crouching while flying forwards is still broken. Still would also like crouch jumping to be added as it would add a layer of skill to movement. |
Or, you know, crouch jumping |
While the latest commit does fix the issue, I think it would feel better if the crouching hitbox shrank up when not grounded |
Also, it would be nice if the player's speed during the crouching animation was also interpolated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that I am slipping off of all blocks now.
a4a8c64
to
8a4fe81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for adding this!
Next time I'd prefer it if you would split PRs like this, I'd prefer to see a separate PR for each feature introduced, and here the features crouching and friction are pretty distinct.
No description provided.