chore(remove kinesis): stop sending events to unified event stream #815
Conversation
jpetto
force-pushed
the
INFRA-1067-stop-sending-events-to-unified-event-stream
branch
from
c94228c to
2b3b884
Compare
| @@ -40,17 +32,6 @@ export default { | |||
| process.env.SQS_PUBLISHER_DATA_QUEUE_URL || | |||
| 'http://localhost:4566/000000000000/pocket-publisher-data-queue', | |||
| }, | |||
| listDeleteQueue: { | |||
There was a problem hiding this comment.
@bassrock i couldn't find any usage of this queue in this repo. i can give it another pass to see if i can figure out why it was here in the first place.
There was a problem hiding this comment.
Gotcha, just makes me wonder what it was... as well, but im cool with rolling forward!
There was a problem hiding this comment.
@bassrock i can't even find this queue in AWS! (nor can i see it created in the .aws directory in main.) looks like it was created by kelvin back when this repo had a different structure...
There was a problem hiding this comment.
since i am not proficient in this repo, i would love confirmation here 😅
according to the existing config, i believe the queue name in infra should be ListAPI-Prod-Sqs-Batch-Delete-Consumer-Queue. i don't see any infra code creating this queue, however. and i don't see a queue in our prod AWS account matching the name above.
on top of that, on the main branch, i can't find any reference outside of the config file referenced here to the variable name listDeleteQueue.
There was a problem hiding this comment.
@jpetto thats safe to delete then. My guess is it was left over from intial account deletion work and the team went a different direction
Goal
stop sending events to unified event stream.
DO NOT MERGE - blocked by https://mozilla-hub.atlassian.net/browse/DIS-366, but getting this ready for when that work completes.
I'd love feedback/perspectives on:
Implementation Decisions
References
Jira ticket: