Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #425 and add more tests #426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #425 and add more tests #426

wants to merge 2 commits into from

Conversation

NeejWeej
Copy link
Collaborator

@NeejWeej NeejWeej commented Jan 9, 2025 •
edited
Loading

Fixes #425

@NeejWeej NeejWeej changed the title Fix #425 and add more tests [WIP] Fix #425 and add more tests Jan 9, 2025
@NeejWeej NeejWeej force-pushed the nk/fix_typing_bug_425 branch from 4ee56cb to 4092860 Compare January 9, 2025 12:17
@NeejWeej NeejWeej force-pushed the nk/fix_typing_bug_425 branch from 6667728 to 3be6dbc Compare January 10, 2025 01:15
@NeejWeej NeejWeej force-pushed the nk/fix_typing_bug_425 branch from 3be6dbc to 8ed0013 Compare January 10, 2025 01:25
@NeejWeej NeejWeej changed the title [WIP] Fix #425 and add more tests Fix #425 and add more tests Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomecek ptomecek ptomecek left review comments

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version 0.0.6 improper type handling on Optional[List]
2 participants
@NeejWeej @ptomecek