Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the Reproduce in Python page, the left arrow button is slightly further right #775

Closed
anth-volk opened this issue Oct 24, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@anth-volk
Copy link
Collaborator

A minor issue, but on the Reproduce in Python page, where there's no arrow to move right, the left arrow moves a bit to the right of where it is for the other pages. I'm not sure if this is an error or more a design choice, but if it is meant to move over, it might be better to have it sit in the same spot as where the right button would usually be. I'll upload a clip later to demonstrate what I mean.

@MaxGhenis MaxGhenis added the good first issue Good for newcomers label Oct 24, 2023
@amar9312
Copy link
Contributor

amar9312 commented Nov 23, 2023

Hi @anth-volk, if we change the blank <div> width to 80, it seems to fix this issue but I wonder if it will be good for all screen sizes. I can create a PR if you approve this.

Thanks, Amar

image

@anth-volk
Copy link
Collaborator Author

Shoot, this may actually be solved by #867, though I forgot to mention it in the PR. Also, I probably should've separated that into multiple PRs in hindsight.

Also, so as to not step on any toes, I'm going to mention @nikhilwoodruff here. The buck ultimately stops with him and @MaxGhenis on these sorts of decisions, so anything I'm saying in any of these comments is merely my opinion.

@MaxGhenis
Copy link
Contributor

Just for posterity the issue is that the pair of buttons is centered, which makes the left one more rightward when the right one vanishes
image

image

@anth-volk
Copy link
Collaborator Author

It looks like part of the problem, too, is that the button itself is built as two divs: the outer applies the hover effect (since inline styling prevents using CSS pseudo-elements to do it) and the inner contains the content. The outer allows for custom styling, if I remember correctly, but the inner requires a fixed width of 60px, so even though the code @amar9312 shared creates a button of 50px square, the inner overflows and makes the button 60x60 or 60x54, I can't remember which.

To proceed, I'm thinking after #867, we could make a few more fundamental edits to the button class that controls this so that it can be resized without having to manually specify sizing.

@Zouziszzm
Copy link

Hello Is this issue solved ? I couldn't find the page. @MaxGhenis @anth-volk

@MaxGhenis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants