-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the Reproduce in Python page, the left arrow button is slightly further right #775
Comments
Hi @anth-volk, if we change the blank Thanks, Amar |
Shoot, this may actually be solved by #867, though I forgot to mention it in the PR. Also, I probably should've separated that into multiple PRs in hindsight. Also, so as to not step on any toes, I'm going to mention @nikhilwoodruff here. The buck ultimately stops with him and @MaxGhenis on these sorts of decisions, so anything I'm saying in any of these comments is merely my opinion. |
It looks like part of the problem, too, is that the button itself is built as two To proceed, I'm thinking after #867, we could make a few more fundamental edits to the button class that controls this so that it can be resized without having to manually specify sizing. |
Hello Is this issue solved ? I couldn't find the page. @MaxGhenis @anth-volk |
It got fixed Sample link for posterity https://policyengine.org/us/household?focus=householdOutput.pythonReproducibility&household=35108 |
A minor issue, but on the Reproduce in Python page, where there's no arrow to move right, the left arrow moves a bit to the right of where it is for the other pages. I'm not sure if this is an error or more a design choice, but if it is meant to move over, it might be better to have it sit in the same spot as where the right button would usually be. I'll upload a clip later to demonstrate what I mean.
The text was updated successfully, but these errors were encountered: