-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useNavigate() runtime issue, thereby re-enabling cookie banner and policies modelled popup #867
Merged
nikhilwoodruff
merged 25 commits into
PolicyEngine:master
from
anth-volk:fix/repair_button
Nov 28, 2023
Merged
Fix useNavigate() runtime issue, thereby re-enabling cookie banner and policies modelled popup #867
nikhilwoodruff
merged 25 commits into
PolicyEngine:master
from
anth-volk:fix/repair_button
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irection' prop to 'hoverEffectStart' to reduce ambiguity
…rrors, add documentation
This was referenced Nov 23, 2023
Closed
nikhilwoodruff
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thanks!
This was referenced Dec 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an error with the deployment of
useNavigate()
, re-enabling all interstitials. It also adds the cookie consent component back into the app, alters some styling on the old component, and adds tests. Finally, it re-enables thePoliciesModelledPopup
and adds a test for it, as well.Note: This also disables a test that currently always fails, as part of issue #836, until further planning can make the test more robust to back-end variable changes.
Fixes #762, #775, #866, and #817. If you'd prefer these broken into multiple PRs, happy to do so; I've lumped them together because each depends upon the other in the following order: solve useNavigate() -> refactor buttons -> re-style cookie banner in accordance with refactored buttons -> solve #775 using refactored buttons
🤖[deprecated] Generated by Copilot at 9a5f053
Summary
🧪🎨🍪
This pull request refactors the navigation and button components, adds new components for cookie consent and arrow buttons, adds new test files for buttons and dialogs, and fixes a test and a console.log statement. The overall purpose is to improve the user interface, the code quality, and the test coverage of the app.
Walkthrough