Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add monthly and eternity variables #756

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

nikhilwoodruff
Copy link
Contributor

@nikhilwoodruff nikhilwoodruff commented Oct 20, 2023

🤖 Generated by Copilot at 0e91b94

Summary

🐛🧹💵

This pull request improves code style and fixes bugs in the household input and output components of the app. It removes unnecessary trailing commas from arrays and function calls, and aligns parentheses for readability. It also fixes the handling of "eternity" variables and the variation of employment income for 2023.

Sing, O Muse, of the code that was refined
By the skillful coder, who removed the commas
That trailed like the tail of a serpent behind
The arrays and functions, causing much drama.

Walkthrough

  • Fix a bug that prevented some variables from being added to the household input by adding "eternity" to the year check condition (link)
  • Fix a bug that caused an error when trying to vary the earnings of the household by modifying the way the householdData object is updated for the year 2023 (link)
  • Remove trailing commas from various array and function calls to improve code style consistency (link, link, link, link, link, link, link, link, link, link, link, link)
  • Move the closing parenthesis of the setSearchParams function call to the next line to improve readability (link)

@nikhilwoodruff nikhilwoodruff self-assigned this Oct 20, 2023
@nikhilwoodruff nikhilwoodruff merged commit 71c8c5c into master Oct 20, 2023
2 checks passed
@nikhilwoodruff nikhilwoodruff deleted the monthly-variables branch October 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant