-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust headline size based on screen size #849
Adjust headline size based on screen size #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@nikhilwoodruff Can you give me more information (screen size, or any condition)? I've tried several responsive sizes but it works still well for the mobile screens. |
Could this at all be a Safari thing? I know you test in Safari, @nikhilwoodruff, and I've found in the past that I have to use more workarounds, vendor prefixes, etc., when working with it. |
Oh, yes! I see, the Safari, let me take a look on it.
Yea, I initially focused on the issue title so I've only fixed for mobile. So I will try to figure out what happened with Safari and fix the responsive for all screen. Btw, tell me if you know anything about why it broke in the Safari. @nikhilwoodruff @anth-volk |
Thanks so much @ductbuix. Not sure I have any useful details to add on the root cause but let me know if you can't reproduce it. |
Yea, I found the issue, but the fix might need some more changes. I'm on it. |
Hi @anth-volk @nikhilwoodruff , I've fixed the responsive header, please check it out. |
Looks great on my machine, thanks @ductbuix! @anth-volk I think the merge conflict is from your PR, would you mind taking a look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge upon the merge conflict being resolved
@nikhilwoodruff It looks good now. |
Fix #757 by adjusting headline font size for mobile view and its responsive container.
π€[deprecated] Generated by Copilot at 6384d6a
Summary
π±π οΈπ¨
Enhanced the design and functionality of the
Hero
component on the home page. Made it adapt to different screen sizes and resolutions usingsrc/redesign/components/HomeLanding.jsx
.Walkthrough
Hero
andHeroText
components to be responsive to the screen size (link, link)HeroTitle
component on mobile to avoid text wrapping or clipping (link)