Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink vertical spacing of the bottom text in Reproduce in Python page #901

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

maurobusso
Copy link
Contributor

@maurobusso maurobusso commented Nov 26, 2023

πŸ€–[deprecated] Generated by Copilot at be218b0

Summary

πŸ“±πŸ› οΈπŸ”₯

Improved the layout and spacing of the results panel on different devices. Removed unnecessary margin from the HouseholdReproducibility component that uses the results panel.

h5 gets padding
results panel looks better
no more marginBottom

Walkthrough

  • Add padding to the results panel description to improve layout on different screen sizes (link)
  • Remove extra margin at the bottom of the results panel in HouseholdReproducibility component (link)

Hi, I am new to OS so I tried this simple issue, I hope it helps.
Fixes #897 .
I made some small adjustment to the ResultsPanel.jsx file on line 24 and to the HouseholdReproducibility.jsx file on line 176 by changing the style.
It seems to display less space between the copy button and the text below.
Let me know if it needs to be modified further.

@MaxGhenis
Copy link
Contributor

Thanks @maurobusso! Could you please link the PR to #897?

@MaxGhenis MaxGhenis changed the title changed vertical spacing of the bottom text in reproduce in phyton page changed vertical spacing of the bottom text in Reproduce in Python page Nov 26, 2023
@MaxGhenis MaxGhenis changed the title changed vertical spacing of the bottom text in Reproduce in Python page Shrink vertical spacing of the bottom text in Reproduce in Python page Nov 26, 2023
@MaxGhenis MaxGhenis merged commit 7f27e54 into PolicyEngine:master Nov 27, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much padding on Reproduce in Python page
2 participants