updated logic for files separately - special cases #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noman404
changed the title
PavelMakarchuk
requested changes
Dec 16, 2024
PavelMakarchuk
requested changes
Dec 18, 2024
state_itemized_deductions state_taxable_income state_income_tax_before_non_refundable_credits added special case for states which failed
|
Al - could you resolve outstanding conversations if ready for review? |
PavelMakarchuk
requested changes
Dec 23, 2024
- code cleanup
# Conflicts: # policyengine_taxsim/config/variable_mappings.yaml
|
@noman404 to run more state tests before merging (either check in here as a test not run in CI--takes too long--or file an issue to check them in elsewhere). |
|
Performed tests for all states for married and single, on mac it takes less than a min, on windows it takes several mins. And it resolved the state_files_separately, pre_simulation cases from yaml. However, still need to cover the special cases where states does not have variable implemented and set 0, like #166 |
|
I'll add the all states tests in the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated logic for 'submission/files separately' special cases for
Mississippi
Arkansas
Montana
Delaware
Iowa
Kentucky
Fixes #131