Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Update polymer-3-element-status.md #271

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Update polymer-3-element-status.md #271

merged 3 commits into from
Jan 29, 2018

Conversation

FredKSchott
Copy link
Contributor

No description provided.

@@ -14,115 +14,113 @@ This table contains the status of every Polymer 3.0 element being run through au

## Support Table

| repo | `npm install` | `npm test` | reason? |
| repo | *npm install* | *npm test* | reason? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be good to show the command used here instead or not tie it to the word npm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, looking at this now this was supposed to stay npm install, wonder if I changed it on purpose or by accident.

These are the commands run within each repo in question. Would $ npm install convey this more? Something else? Open to suggestions!

Copy link
Contributor

@stramel stramel Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that point until you mentioned it. 👍 I think it is fine with just the back ticks

I was thinking that you were using yarn install instead of npm install since AFAIK flat: true in the package.json won't do anything unless using yarn currently.

// TODO(fks): Get `yarn install --flat` working to test flat install
// See: https://github.com/Polymer/polymer-modulizer/issues/254
return exec(repo.dir, 'npm', ['install']);
Also, AFAIK, the NPM front-end asset manager is still PoC at best? (package-community/discussions#2)

Secondly, the package.json we are generating is not generating or inheriting a scripts section which is where NPM looks for the command to run when npm test is called. So with that being said, I saw that you are using wct --npm for the test command currently.

const {stdout, stderr} = await exec(repo.dir, 'wct', ['--npm']);
How will we handle repos like paper-input which can't run both browsers in parallel?

So currently I would imagine it being:

| repo | `npm install` | `wct --npm` | reason? |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stramel great point, I agree | repo | npm install|wct --npm | reason? | makes the most sense here, with a note about why we're testing npm install vs. yarn install at the moment.

@justinfagnani
Copy link
Contributor

@FredKSchott should the be updated as of yesterday?

@FredKSchott
Copy link
Contributor Author

Merging this now so that we show the latest data as linked to from the blog post, can address table headers in future PR

@FredKSchott FredKSchott merged commit fb4a6b0 into master Jan 29, 2018
@FredKSchott FredKSchott deleted the FredKSchott-patch-1 branch January 29, 2018 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants