fix: Renamed some properties to match posthog-js (#130)

PostHog · Dec 4, 2023 · 53400c7 · 53400c7
1 parent 14ceeab
commit 53400c7
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 4 deletions.
diff --git a/posthog-core/src/index.ts b/posthog-core/src/index.ts
@@ -867,7 +867,7 @@ export abstract class PostHogCore extends PostHogCoreStateless {
   /***
    * PROPERTIES
    ***/
-  personProperties(properties: { [type: string]: string }): this {
+  setPersonPropertiesForFlags(properties: { [type: string]: string }): this {
     // Get persisted person properties
     const existingProperties =
       this.getPersistedProperty<Record<string, string>>(PostHogPersistedProperty.PersonProperties) || {}
@@ -880,7 +880,16 @@ export abstract class PostHogCore extends PostHogCoreStateless {
     return this
   }
 
-  groupProperties(properties: { [type: string]: Record<string, string> }): this {
+  resetPersonPropertiesForFlags(): void {
+    this.setPersistedProperty<PostHogEventProperties>(PostHogPersistedProperty.PersonProperties, {})
+  }
+
+  /** @deprecated - Renamed to setPersonPropertiesForFlags */
+  personProperties(properties: { [type: string]: string }): this {
+    return this.setPersonPropertiesForFlags(properties)
+  }
+
+  setGroupPropertiesForFlags(properties: { [type: string]: Record<string, string> }): this {
     // Get persisted group properties
     const existingProperties =
       this.getPersistedProperty<Record<string, Record<string, string>>>(PostHogPersistedProperty.GroupProperties) || {}
@@ -902,6 +911,15 @@ export abstract class PostHogCore extends PostHogCoreStateless {
     return this
   }
 
+  resetGroupPropertiesForFlags(): void {
+    this.setPersistedProperty<PostHogEventProperties>(PostHogPersistedProperty.GroupProperties, {})
+  }
+
+  /** @deprecated - Renamed to setGroupPropertiesForFlags */
+  groupProperties(properties: { [type: string]: Record<string, string> }): this {
+    return this.setGroupPropertiesForFlags(properties)
+  }
+
   /***
    *** FEATURE FLAGS
    ***/

diff --git a/posthog-react-native/CHANGELOG.md b/posthog-react-native/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 2.9.0 - 2023-12-04
+
+1.  Renamed `personProperties` to `setPersonPropertiesForFlags` to match `posthog-js` and more clearly indicated what it does
+2.  Renamed `groupProperties` to `setGroupPropertiesForFlags` to match `posthog-js` and more clearly indicated what it does
+
 # 2.8.1 - 2023-10-09
 
 1. Fixes a type generation issue

diff --git a/posthog-react-native/package.json b/posthog-react-native/package.json
@@ -1,6 +1,6 @@
 {
   "name": "posthog-react-native",
-  "version": "2.8.1",
+  "version": "2.9.0",
   "main": "lib/posthog-react-native/index.js",
   "files": [
     "lib/"

diff --git a/posthog-web/CHANGELOG.md b/posthog-web/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 2.5.0 - 2023-12-04
+
+1.  Renamed `personProperties` to `setPersonPropertiesForFlags` to match `posthog-js` and more clearly indicated what it does
+2.  Renamed `groupProperties` to `setGroupPropertiesForFlags` to match `posthog-js` and more clearly indicated what it does
+
 # 2.4.0 - 2023-04-20
 
 1. Fixes a race condition that could occur when initialising PostHog

diff --git a/posthog-web/package.json b/posthog-web/package.json
@@ -1,6 +1,6 @@
 {
   "name": "posthog-js-lite",
-  "version": "2.4.0",
+  "version": "2.5.0",
   "main": "lib/index.cjs.js",
   "module": "lib/index.esm.js",
   "types": "lib/index.d.ts",